fix(issues): Anchor issue preview hovercard to the visible title - #121919
Draft
ChrisandraVaz wants to merge 1 commit into
Draft
fix(issues): Anchor issue preview hovercard to the visible title#121919ChrisandraVaz wants to merge 1 commit into
ChrisandraVaz wants to merge 1 commit into
Conversation
The hovercard positions itself against the wrapper useHoverOverlay puts around the trigger. That wrapper carries max-width: 100%, but it was display: inline, where max-width does nothing -- so on a title truncated by an ancestor its layout box ran the full untruncated width and the hovercard landed out past the visible edge. Measured 226px adrift on a stream row whose title cuts off mid-path. Switching the wrapper to inline-block alone would regress #79570, which set inline deliberately so long titles ellipsize. Moving the truncation onto the wrapper keeps both: it clips and renders the ellipsis itself, and reports a box that stops where the title stops. vertical-align is pinned because overflow: hidden on an inline-block moves the baseline to the bottom margin edge, which shifts the title against the bookmark icon. Affects every surface rendering a group title with a preview: the issue stream, trace drawer, feedback crash reports, similar issues, and detector open periods.
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long issue titles get truncated, but the hovercard anchored to the title's full untruncated width — so the card landed ~226px past where the text visually ends, looking detached from its row.
The trigger is now
inline-blockwith the truncation moved onto it, so it reports the width you can actually see. Plaininline-blockwould have undone #79570, which usedinlineto get the ellipsis working.Before
After
Affects the issue stream, trace drawer, feedback crash reports, similar issues, and detector open periods. Bookmarked issues are still off by the star's width (~17px).