fix(coding-conventions): Rename Tree.FromAssertion to Tree.fromAssertion - #121920
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
ryan953
added
the
Trigger: getsentry tests
ryan953
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an ESLint warning
no-capitalized-function-callsthat was triggered by the static factory methodTree.FromAssertioninstatic/app/views/detectors/components/uptime/assertions/assertionFailure/models/tree.tsx.The
no-capitalized-function-callsrule is designed to prevent React components from being invoked as plain functions (e.g.,MyComponent()instead of<MyComponent />). BecauseFromAssertionwas PascalCase, the linter incorrectly flagged it as a potential React component call.To resolve this, the static method
FromAssertionhas been renamed tofromAssertion(camelCase) to align with standard JavaScript/TypeScript naming conventions for non-component functions. All call sites instatic/app/views/detectors/components/uptime/assertions/assertionFailure/assertionFailureTree.tsxandstatic/app/views/detectors/components/uptime/assertions/assertionFailure/models/tree.spec.tsxhave been updated accordingly.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Consolidated: issue CODING-CONVENTIONS-1TE reported a stale/renamed file path that resolves to this same
Tree.FromAssertioncall site (superseded PR #121922 closed as duplicate).Fixes CODING-CONVENTIONS-3XX
Fixes CODING-CONVENTIONS-1TE