fix(coding-conventions): Address no-capitalized-function-calls in viewHierarchy utils - #121921
Open
sentry[bot] wants to merge 2 commits into
Open
fix(coding-conventions): Address no-capitalized-function-calls in viewHierarchy utils#121921sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
ryan953
added
the
Trigger: getsentry tests
The no-capitalized-function-calls rule flags capitalized function calls because they read as React component invocations. Rect.Empty() tripped it in viewHierarchy utils. Rename the static method itself rather than avoiding the call, matching the convention fix applied elsewhere. All 16 call sites are updated. FlamegraphChart.Empty and Flamegraph.Empty are separate symbols and are left untouched.
github-actions
Bot
removed
the
Trigger: getsentry tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
no-capitalized-function-callslint rule, part of the React Compiler's lint suite, flagged the call toRect.Empty()instatic/app/components/events/viewHierarchy/utils.tsx.This rule prohibits calling capitalized functions that are not React components, as the compiler uses capitalization to distinguish components.
Rect.Empty()is a static factory method, not a React component, and thus violated this convention.This change replaces
Rect.Empty()withnew Rect(0, 0, 0, 0)at the flagged call site within theuseResizeCanvasObserverhook. Other usages ofRect.Empty()in the codebase were not affected as they occur in contexts (e.g., class property initializers) where this specific lint rule does not apply.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-1P3