ref(flamegraph): Rename STACK_TO_COLOR to stackToColor for ESLint compliance - #121924
Open
sentry[bot] wants to merge 3 commits into
Open
ref(flamegraph): Rename STACK_TO_COLOR to stackToColor for ESLint compliance#121924sentry[bot] wants to merge 3 commits into
sentry[bot] wants to merge 3 commits into
Conversation
ryan953
reviewed
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
STACK_TO_COLORproperty within the flamegraph theme tostackToColor.Why this change?
The previous
STACK_TO_COLORnaming convention violated theno-capitalized-function-callsESLint rule, which flags function calls where the callee name starts with a capital letter (conventionally reserved for constructors). The flamegraph theme'sCOLORSobject used an ALL_CAPS convention for both constant values and callable functions, leading to this linter error whenSTACK_TO_COLORwas invoked.What was changed?
FlamegraphThemetype definition inflamegraphTheme.tsx.flamegraphTheme.tsx.makeStackToColorinutils/profiling/colors/utils.tsx.flamegraphRenderer.tsxandaggregateFlamegraphTreeTable.tsx.flamegraphRendererWebGL.spec.tsxto reflect the new name and removed the now-unnecessary@ts-expect-errorcomment.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-1QB