Repository navigation
Conversation
Download version-1 flamegraph attachments and adapt their independent call trees to the existing count-based profiling visualization. Keep MetricKit rendering unchanged and gate the new viewer behind the flamegraph attachment feature flag.
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-b5afbxnmv.sentry.dev |
📊 Type Coverage Diff
🔍 8 new type safety issues introducedNon-null assertions (
Type assertions (
This is informational only and does not block the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit abc84f3. Configure here.
…egraph-attachment-ui
|
@scttcper I slightly adapted the algorithm to reconstruct the tree due to changes in the (draft) file changes here: getsentry/sentry-docs#20073 No visual changes, tried it locally using https://sentry-sdks.sentry.io/issues/7738016221/events/8b04e1bf48504280842443da5575c9fb/ but disabling the feature flag check, as the flag has not been merged yet: https://github.com/getsentry/sentry-options-automator/pull/10184 |
Sentry Snapshot Testing
Base commit |

Adds a dedicated Flamegraph section to issue details when an event has a version-1
event.flamegraphattachment. It uses the existing attachment listing and download endpoints, with loading, explicit retry, and unsupported-format handling. The section is gated byevent-attachmentsandflamegraph-attachments.The viewer reuses the profiling canvas, theme, hover tooltips, and scrolling used by MetricKit flamegraphs without changing the existing MetricKit implementation. A separate adapter converts attachment nodes into weighted paths, preserving inclusive counts, samples ending at intermediate nodes, repeated frames, and recursion. Multiple attachments and call trees can be selected independently. Unclassified frames use the system-frame color.
Backend prerequisite: #126459. Land the backend first so the feature flag is exposed to the UI.
The 33 focused tests include the existing MetricKit and view-hierarchy suites. Full frontend typechecking and lint passed. Playwright verification against a local event attachment confirmed a painted canvas, independent tree counts, hover tooltips, scrolling, and collapse persistence. Diagnostic payloads and browser artifacts are not included.