Repository navigation
perf(metrics): keep unchanged metric panels stable when another panel changes - #128357
Draft
JoshuaKGoldberg wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
… changes Row mutators hand updater functions to setQueries instead of closing over the rendered queries, and decoded queries are cached per URL value and index, so unchanged panels keep the same query params and mutators. The URL-backed provider moves onto nuqs, whose setter is stable and composes queued writes.
JoshuaKGoldberg
force-pushed
the
joshgoldberg/logs-1035-functional-metric-query-setters
branch
from
October 21, 2026 15:34
3de35e2 to
f512f71
Compare
JoshuaKGoldberg
changed the title
…lapsing-metrics' into joshgoldberg/logs-1035-functional-metric-query-setters
JoshuaKGoldberg
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unchanged metric panels now keep the same query params and mutators when another panel changes, because row mutators hand updater functions to
setQueriesinstead of closing over the rendered queries.This is done by:
setQueriesnuqsand its nice stable setterSplit out of #128357 so we don't have to use esoteric React hooks.