-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(streams): operator control server #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bmcquilkin-sentry
wants to merge
6
commits into
pod-management-v2
Choose a base branch
from
bmcquilkin/runtime/control-server
base: pod-management-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8166a2
feat(operator): control server and generic runner
bmcquilkin-sentry 60d8710
ref(controller): exception semantics
bmcquilkin-sentry 07c338f
ref(controller): use ThreadPoolExecutor + Future
bmcquilkin-sentry d9dd62f
ref(controller): redundant request_stop
bmcquilkin-sentry 774e218
chore(server): better docstring
bmcquilkin-sentry 4937081
chore(controller): better docstring
bmcquilkin-sentry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import threading | ||
| from concurrent.futures import Future, ThreadPoolExecutor | ||
| from typing import Any | ||
|
|
||
| from sentry_streams.adapters.stream_adapter import ( | ||
| RuntimeStatus, | ||
| StreamAdapter, | ||
| ) | ||
|
|
||
|
|
||
| class PipelineController: | ||
| """ | ||
| Control panel for one streaming pipeline. Starts the adapter's blocking run loop | ||
| in a background thread and allows concurrent requests to start/stop the pipeline. | ||
|
|
||
| A pipeline is single-use: after it stops or fails, it cannot be restarted. | ||
| A replacement deployment must create a new controller and adapter. | ||
|
|
||
| Start and stop requests can arrive concurrently from HTTP handler and process | ||
| shutdown threads. The lock prevents state transition race conditions. | ||
| """ | ||
|
|
||
| def __init__(self, runtime: StreamAdapter[Any, Any]) -> None: | ||
| self._runtime = runtime | ||
| self._lock = threading.Lock() | ||
| self._executor = ThreadPoolExecutor(max_workers=1, thread_name_prefix="pipeline-run") | ||
| self._run_future: Future[None] | None = None | ||
| self._finished = threading.Event() | ||
|
|
||
| @property | ||
| def snapshot(self) -> RuntimeStatus: | ||
| return self._runtime.status | ||
|
|
||
| def request_start(self) -> RuntimeStatus: | ||
| """ | ||
| Ask the pipeline to start (non-blocking). | ||
| """ | ||
| with self._lock: | ||
| status = self._runtime.begin_start() | ||
| if self._run_future is None: | ||
| self._run_future = self._executor.submit(self._runtime.run) | ||
| self._run_future.add_done_callback(self._run_finished) | ||
| return status | ||
|
|
||
| def request_stop(self) -> RuntimeStatus: | ||
| """ | ||
| Ask the pipeline to stop (non-blocking). | ||
| """ | ||
| with self._lock: | ||
| status = self._runtime.shutdown() | ||
| if self._run_future is None: | ||
| self._finished.set() | ||
| self._executor.shutdown(wait=False) | ||
|
|
||
| return status | ||
|
|
||
| def wait_until_finished(self, timeout: float | None = None) -> RuntimeStatus: | ||
| """ | ||
| Wait until this controller is completely finished. | ||
| """ | ||
| if not self._finished.wait(timeout): | ||
| return self._runtime.status | ||
|
|
||
| with self._lock: | ||
| run_future = self._run_future | ||
|
|
||
| if run_future is not None: | ||
| run_future.result() | ||
|
|
||
| return self._runtime.status | ||
|
|
||
| def wait_until_stopped(self, timeout: float | None = None) -> RuntimeStatus: | ||
| """ | ||
| Wait for a started pipeline's background thread to exit. | ||
| """ | ||
| self._finished.wait(timeout) | ||
| return self._runtime.status | ||
|
|
||
| def _run_finished(self, _future: Future[None]) -> None: | ||
| self._finished.set() | ||
| self._executor.shutdown(wait=False) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.