Skip to content

feat(taskworker): Add child fetch wait duration metric #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enochtangg merged 1 commit into from
Aug 27, 2026
Merged

feat(taskworker): Add child fetch wait duration metric #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions clients/python/src/taskbroker_client/worker/workerchild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,15 +408,33 @@ def check_task_future_completion(
local_shutdown.set()
break

fetch_wait_start = time.monotonic()
try:
inflight = child_tasks.get(timeout=1.0)
except queue.Empty:
metrics.distribution(
"taskworker.worker.child.fetch_wait_duration",
time.monotonic() - fetch_wait_start,
tags={
"processing_pool": processing_pool_name,
"outcome": "empty",
},
)
metrics.incr(
"taskworker.worker.child_task_queue_empty",
tags={"processing_pool": processing_pool_name},
)
continue

metrics.distribution(
"taskworker.worker.child.fetch_wait_duration",
time.monotonic() - fetch_wait_start,
tags={
"processing_pool": processing_pool_name,
"outcome": "task",
},
)

# Open the busy segment as soon as we have a task. The slot is now
# unavailable for new work, whatever stage of handling it is in.
messages.put_nowait(ChildMessage(child_id, "busy"))
Expand Down
Loading