Skip to content

Move install-dir and Windows PATH handling into cli setup #1535

Closed

Description

@sentry-junior

The CLI's install directory is worked out in three places, and Windows PATH persistence lives only in the PowerShell installer. Follow-up to #1511.

  • Install directory: determineInstallDir() in packages/cli/src/lib/binary.ts, the SENTRY_INIT=1 branch of packages/cli/install, and Resolve-InstallDir in packages/cli/install.ps1 each implement the same SENTRY_INSTALL_DIR → XDG_BIN_HOME → ~/.local/bin/~/bin lookup and have to be kept in sync by hand.
  • Windows PATH: sentry cli setup only edits POSIX shell rc files. install.ps1 writes the user Path registry value itself (keeping %VAR% entries via REG_EXPAND_SZ), appends to GITHUB_PATH, and calls setup with --no-modify-path.
  • Scope (reviewer proposal on feat(cli): Add a PowerShell installer for Windows #1511): have sentry cli setup own both, and remove the duplicated logic from the installers.

via byk.

--

View Junior Session [Sentry]

Activity

  1. linear-code commented on Oct 17, 2026

    @linear-code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions