Repository navigation
ci: Run package checks from the test.yml matrix - #1778
Merged
Merged
Conversation
Move the @sentry/mcp-server clean-consumer typecheck from its own path-filtered workflow into `sentryCi.e2e: "test:package"`, matching @sentry/logger. The test.yml matrix already selects the package when it or a workspace dependency changes, and its `test` job is the required check. Document `package.json#sentryCi` in AGENTS.md, the quality checks guide, and the GitHub Actions guide. Add a workflow policy test that fails when a workflow runs on pull requests without a listed reason, pointing contributors to `sentryCi` instead. Fixes #1777 Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 1, 2026
BYK
enabled auto-merge (squash)
November 1, 2026 16:23
sentry-junior Bot
added a commit
that referenced
this pull request
Nov 1, 2026
Conflicts: - packages/mcp-core/src/server.ts: keep #1780's maxToolInputElements on the single SDK v2 McpServer this branch builds. - packages/mcp-core/src/server.test.ts: keep both imports, and run #1780's input-cap test once, since buildServer no longer takes sdkVersion. - packages/mcp-server/package.json: keep the bundle package. #1778's test:package consumer check typechecks the old library exports, which the bundle no longer ships, so drop it and its test/package files. - package.json, AGENTS.md: keep both sides.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for a single package should run from the
test.ymlper-project matrix, set up throughpackage.json#sentryCi. Nothing pointed contributors or agents there, so #1773 first added a standalonelogger-package.yml, copying the existingmcp-server-package.yml.@sentry/mcp-serverclean-consumer typecheck into the matrix. It's nowsentryCi.e2e: "test:package", laid out like@sentry/logger's check:test/package/check.shplus aconsumer/fixture with the sameindex.tsthe workflow used to write inline.mcp-server-package.ymlis removed. The matrix already selects the package when it or one of its workspace dependencies (mcp-core,mcp-server-mocks, the tsconfig package) changes, and for root changes and pushes tomain. The check now also sits behind the requiredtestjob; before, "Clean Consumer Typecheck" was not a required check. One small difference: matrix E2E steps run on Node 24, while the old workflow ran on Node 22.sentryCi.docs/operations/github-actions.mdgets a "Package CI checks" section: the default script for each field, the override fields, an example, and when a separate workflow is still justified.AGENTS.mdanddocs/contributing/quality-checks.mdadd a short rule that links to it.scripts/workflow-policy.test.mjs, run bytest:ci-projectsin the quality job, fails when a workflow triggers onpull_request,pull_request_target, ormerge_groupand isn't on its list with a reason. The failure message points tosentryCi. The existing PR workflows are on the list: eval, install scripts, Local multi-OS E2E, PR risk, smoke tests, and token cost.Fixes #1777
via @BYK.
--
View Session in Sentry