Bump version to 1.0.0-beta.3 - #173
Merged
Merged
Conversation
The release workflow verifies that the tag being published matches the Version constant, since the constant cannot be stamped in at link time. Tagging v1.0.0-beta.3 against a tree still declaring 0.30.0 failed that check, so the constant is moved to match. 1.0.0-beta.3 rather than beta.0: v1.0-beta.0, v1.0-beta.1 and v1.0.0-beta.2 are already published releases from 2022-2023 with binaries attached, and the first two are not valid semver for GoReleaser besides. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
version/version.go:0.30.0→1.0.0-beta.3.Why
The release workflow refuses to publish a tag that disagrees with the
Versionconstant — the constant is a compile-time string, so it cannot be stamped in at link time and has to be bumped by hand before tagging. Publishingv1.0.0-beta.3against a tree still declaring0.30.0failed that check, and the Release job was skipped:Why beta.3 and not beta.0
v1.0-beta.0,v1.0-beta.1andv1.0.0-beta.2already exist as published releases from 2022–2023, each with a full set of binaries and achecksums.txtattached. Reusing those names would mean deleting live download URLs. The first two are also two-component and not valid semver, which GoReleaser v2 rejects.For the reviewer
Merging this does not by itself fix the failed release. The tag
v1.0.0-beta.3currently points at185f785; once this lands it has to be moved onto the merge commit and force-pushed before the workflow is re-run.Two things outside this PR still gate a working release:
HOMEBREW_TAP_TOKENis not set on this repo (actions/secretsreturnstotal_count: 0). Without it GoReleaser'sskip_uploadtemplate evaluates totrueand the cask push is skipped silently — the release goes green while the tap gets nothing.ghost.rbwas removed in preparation for the migration tohomebrew_casks, which writes toCasks/ghost.rb. Until a release lands,brew install ghost-language/ghost/ghosthas nothing to resolve.A
workflow_dispatchdry run (run 33341148701) passed end to end and produced all nine archives plus the cask, so the pipeline itself is sound.🤖 Generated with Claude Code