Repository navigation
docs(fork): the header is the ledger's single source, commits named by subject - #480
Merged
Merged
Conversation
…y subject Every ledger file's front-matter names the commits it carries by subject and holds the only copy of the change's state; the Status, Upstream and Our commit bullets move verbatim under a History section. ledger-header.sh checks the header, that no subject is named twice and, from the merge base with the mirrored upstream main, that every carried commit is named by exactly one file unless fork/EXEMPT covers it. The agentgateway pin chores, the e2e, ci and sync fixes, the Renovate and boilerplate chores go to the fork-infrastructure file; the Google token minting to the further-credential-providers file; the egress-policy contract rename, the x/net bump, the single-chart render and the fork migrations ledger to their files; the three release-1.3-only files become dropped on this ledger. Proposal: giantswarm/kagent-upstream#719. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
…ur commits Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
marked this pull request as ready for review
October 19, 2026 14:06
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #478 a file states its upstream state twice, in the header and in the
Status/Upstream/Our commitbullets, and only the header is checked, so the bullets drift. The header named the carried commit by SHA, which every re-pin rewrites, seven files had no commit at all, and nothing checked that every commit ongiantswarmhas a file: twenty had none (the agentgateway dataplane pin chores, the credential-provider split, e2e and sync fixes).Change
The header is the ledger's single source:
commitslists the carried subjects (stable across re-pins), the three bullets go and their text moves verbatim under## History, the three release-1.3-only files becomedropped.fork/EXEMPTnames the commit classes that need no file, and the schema check gains--complete: every other commit between the pin andgiantswarmis named by exactly one file. Decision on giantswarm/kagent-upstream#719.