Add AccessLint scan engine - #241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AccessLint as an additional built-in scan engine in the find GitHub Action, alongside Axe, with selection controlled via the scans input while preserving the default behavior (Axe-only when scans is omitted).
Changes:
- Introduces an AccessLint scan path (
runAccesslintScan) and wires it intofindForUrlbased on a new scans context flag. - Updates
scansparsing logic to treataxeandaccesslintas core engines and everything else as plugin names. - Adds dependencies and test coverage for the new scan engine, plus updates action input documentation.
Show a summary per file
| File | Description |
|---|---|
| .github/actions/find/tests/findForUrl.test.ts | Adds tests ensuring AccessLint runs when selected and composes with Axe/plugins. |
| .github/actions/find/src/scansContextProvider.ts | Extends scan-selection context to include AccessLint and adjusts plugin detection. |
| .github/actions/find/src/findForUrl.ts | Adds AccessLint scan execution and maps AccessLint violations into findings. |
| .github/actions/find/package.json | Adds @accesslint/playwright and @playwright/test dependencies. |
| .github/actions/find/package-lock.json | Locks new dependencies and updates Playwright resolution. |
| .github/actions/find/action.yml | Documents new core engine behavior for the scans input. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- .github/actions/find/package-lock.json: Generated file
- Files reviewed: 5/6 changed files
- Comments generated: 5
…nd pass UrlConfig in tests) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…totype # Conflicts: # .github/actions/find/src/findForUrl.ts # README.md
JoyceZhu
reviewed
Jun 29, 2026
Co-authored-by: Joyce Zhu <joycezhu@github.com>
JoyceZhu
reviewed
Jul 1, 2026
Co-authored-by: Joyce Zhu <joycezhu@github.com>
JoyceZhu
reviewed
Jul 1, 2026
# Conflicts: # .github/actions/find/action.yml # .github/actions/find/src/scansContextProvider.ts
JoyceZhu
approved these changes
Jul 6, 2026
Merged
taarikashenafi
added a commit
that referenced
this pull request
Jul 24, 2026
## Summary Cuts the v3.4.0 minor release by merging the reviewed changes on `main` since immutable release `v3.3.0` into the stable `v3` action branch. ### What's new - **NPM scanner plugins** — object entries in `scans` can install and load allowlisted first-party packages at runtime, including a pinned version ([#242](#242)). - **AccessLint engine** — `accesslint` is available as a built-in alternative or complement to Axe, with comparison and selection guidance ([#241](#241)). - **Alt-text plugin documentation** — documents `@github/accessibility-scanner-alt-text-plugin` and the object `scans` configuration ([#247](#247)). ### Maintenance - Update `ruby/setup-ruby` ([#246](#246), [#248](#248)). - Update `actions/setup-node` and patched `brace-expansion` ([#248](#248), [#249](#249)). ## Upgrade notes This is additive and backward-compatible. Existing workflows using `github/accessibility-scanner@v3` need no configuration changes. Axe remains the default when `scans` is omitted. To pin the currently published alt-text plugin: ```yaml scans: | ["axe", {"name": "alt-text-scan", "package": "@github/accessibility-scanner-alt-text-plugin", "version": "1.0.0"}] ``` Only allowlisted first-party NPM plugins are loaded. Package lifecycle scripts are disabled during installation. ## Validation - `npm run lint` — passed on `main` at `096ac67` - `npm run format:check` — passed - Action unit tests — 81 passed - `.github/actions/find` TypeScript build — passed - Repository `Test` workflow — passed: https://github.com/github/accessibility-scanner/actions/runs/30118540795 - Manual local integration using `@github/accessibility-scanner-alt-text-plugin@1.0.0` with object `scans` syntax — package installed and loaded through the scanner plugin manager; a local page with `alt="image.jpg"` produced the expected `filename-alt-text` finding - Root production dependency audit — 0 vulnerabilities ## Release procedure after approval 1. Merge this PR using a merge commit, preserving the established `main` → `v3` release history. 2. Validate the resulting `v3` commit. 3. Publish immutable GitHub release/tag `v3.4.0` from `v3` and verify `github/accessibility-scanner@v3` and `v3.4.0` contain #242 and the intended release delta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility/issues/10666
Adds AccessLint as a built-in scan engine alongside Axe. Opt in via the
scansinput, e.g.["axe", "accesslint"]. With noscansinput the default stays axe-only.