Skip to content

Update Guidepup to 0.29.2 and replace setup-action with @guidepup/setup - #68

Closed
JoyceZhu with Copilot wants to merge 3 commits into
mainfrom
copilot/update-guidepup-to-version-0-29-2
Closed

Update Guidepup to 0.29.2 and replace setup-action with @guidepup/setup#68
JoyceZhu with Copilot wants to merge 3 commits into
mainfrom
copilot/update-guidepup-to-version-0-29-2

Conversation

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Bumps @guidepup/guidepup to 0.29.2 and migrates CI from the guidepup/setup-action GitHub Action to the @guidepup/setup npm package, following the upstream reference pattern.

Changes

  • package.json@guidepup/guidepup: ^0.25.0^0.29.2
  • .github/workflows/test.yml — replace uses: guidepup/setup-action@<sha> with explicit npx invocations in both macOS and Windows jobs:
- run: npx -y --min-release-age=0 @guidepup/setup@0.24.1 setup --ci
- run: npx -y --min-release-age=0 @guidepup/setup@0.24.1 install

Copilot AI changed the title Update Guidepup to 0.29.2 and migrate from setup-action to @guidepup/setup Update Guidepup to 0.29.2 and replace setup-action with @guidepup/setup Jul 28, 2026
Copilot AI requested a review from JoyceZhu July 28, 2026 05:17
@JoyceZhu

Copy link
Copy Markdown
Contributor

@copilot log the lastSpokenPhrase for VoiceOver / spokenPhraseLog for NVDA content so I can debug the assertion failure on CI.

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot log the lastSpokenPhrase for VoiceOver / spokenPhraseLog for NVDA content so I can debug the assertion failure on CI.

Done in the latest commit. Both test files now log the SR output before the assertion:

  • VoiceOver (voiceover.spec.mjs): console.log("VoiceOver lastSpokenPhrase:", lastSpokenPhrase)
  • NVDA (nvda.spec.mjs): console.log("NVDA spokenPhraseLog:", spokenPhraseLog)

@JoyceZhu

Copy link
Copy Markdown
Contributor

@copilot, try increasing the timeout in the page.waitForTimeout calls which occur immediately typing the letter "a" in both the VoiceOver and NVDA test suites to 10000.

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot, try increasing the timeout in the page.waitForTimeout calls which occur immediately typing the letter "a" in both the VoiceOver and NVDA test suites to 10000.

Done — both page.waitForTimeout(4000) calls immediately after type("a") have been updated to page.waitForTimeout(10000) in voiceover.spec.mjs and nvda.spec.mjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants