Repository navigation
docs(instructions): modernize nextjs-tailwind for Next.js 15+ and Tailwind v4 (#5114) 🤖🤖🤖 - #5129
fncreator22 wants to merge 4 commits into
Conversation
|
@all-contributors add @fncreator22 for doc, content |
🔒 PR Risk Scan ResultsScanned 1 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
🚦 Submission status: 🛠️ Requires submitter fixesRisk tier: Why this tier
Automated checks
Action needed
Review
Commands
Updated for |
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
|
/request-review |
|
I've put up a pull request to add @fncreator22! 🎉 |
|
🙋 Added |
aaronpowell
left a comment
There was a problem hiding this comment.
Thanks for picking this up from #5114. A few things before merge:
applyTodrops**/*.css, but the Tailwind v4 section is aboutglobals.css, so it never loads there. Please add CSS (and considerlib/**).instructions/nextjs.instructions.mdalready targets Next.js 16 with Cache Components; this file centres onfetchcache options. Please align, or narrow this file to Tailwind-in-Next.js specifics.priorityonnext/imageis deprecated in Next.js 16 (usepreload) — scope to 15.x or update.- Trim generic lines (strict TypeScript, dark: variants, inline arbitrary values).
|
Thanks for the review and clear pointers, @aaronpowell! I have updated the file to address each item:
Ran build and validation scripts locally, and line endings are verified as LF. |
|
/request-review |
|
/rerun-checks |
|
🙋 Added |
|
🔁 Re-running: The status comment updates when the checks finish. |
aaronpowell
left a comment
There was a problem hiding this comment.
Thanks for restoring CSS/lib coverage and correcting preload versus priority. Item 2 remains incomplete: instructions/nextjs-tailwind.instructions.md:16–53 still contains general component-boundary, async-request and server-action guidance covered by nextjs.instructions.md. Please replace that block with a short pointer and trim the general performance/route-boundary advice at 84–88. Keep the CSS-first configuration and class-merging helper as the focused core. Please also cite the relevant version-specific documentation and describe a realistic Copilot usage check; build and manifest validation alone do not establish the guidance's behavior.
|
Thanks for narrowing this to the Tailwind v4 core and removing the general Next.js material. The remaining review items are still open: please link directly to the version-specific Next.js documentation supporting |
|
Thanks for the follow-up review, @aaronpowell! I have updated the PR to resolve the remaining items:
All local validation gates pass cleanly with normalized LF line endings. Could you please reopen this PR for review? |
Summary of Changes
Modernizes
instructions/nextjs-tailwind.instructions.mdto reflect production standards for Next.js 15+ (App Router) and Tailwind CSS v4, resolving the maintainer staleness audit flagged in #5114.Key Updates
applyTofrom global'**/*.{ts,tsx,jsx,js,css}'to App Router and component directories ('app/**/*.{ts,tsx,js,jsx}, src/app/**/*.{ts,tsx,js,jsx}, components/**/*.{ts,tsx,js,jsx}') to prevent context pollution in unrelated files.await params,await searchParams,await cookies(), andawait headers().no-store)fetchand route handler behavior with explicitforce-cacheand revalidation tag patterns.useActionState(replacing deprecateduseFormState).@import "tailwindcss";and@themeroot CSS configurations instead of legacytailwind.config.js.docs/README.instructions.mdvianpm run build.Verification & Validation
npm run buildexecuted successfully; documentation in sync.npm run skill:validatepassed (435/435 skills valid).npm run plugin:validatepassed (104/104 plugins and external catalog valid).git diff --checkclean).eng/pr-risk-scan.mjs) returned 0 findings.Resolves part of #5114.