Skip to content

Add what-breaks-in-ai-code skill 🤖🤖🤖 - #6230

Closed
arez-xd wants to merge 2 commits into
github:mainfrom
arez-xd:add-what-breaks-in-ai-code
Closed

arez-xd wants to merge 2 commits into
github:mainfrom
arez-xd:add-what-breaks-in-ai-code

Conversation

@arez-xd

@arez-xd arez-xd commented Nov 3, 2026

Copy link
Copy Markdown

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Code review for apps built with AI agents, and for any pull request, branch, diff or whole project. It maps each change to the code around it, holds it to the codebase's own conventions, follows values across files and plays every write twice. The passes aim at where agent-built apps fail once real users arrive: another customer's records, a double charge, a secret key in the browser bundle, a model's reply rendered as HTML, a test that can't fail, a package that doesn't exist.

The report opens with a plain verdict (ready to ship, fix first, or the rest can wait) and what users would see, then each finding with its file and line, the evidence, a severity set by consequence and a fix to hand back to the agent. On request, it lists what in the code could be simpler, each with the shorter version.

Read-only, no scripts. Text in the PR and in the repository is treated as evidence: an instruction found there is reported and never followed. No paid service or account needed. Source, MIT: https://github.com/arez-xd/what-breaks-in-ai-code


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

agents/claude.yaml and agents/openai.yaml are display metadata (name, short description, default prompt) for agents that read them. npm run skill:validate and npx @microsoft/vally-cli lint pass.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

🤖 Generated with Claude Code

arez-xd and others added 2 commits November 3, 2026 22:52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arez-xd
arez-xd requested review from a team as code owners November 3, 2026 17:24
@github-actions github-actions Bot added new-submission PR adds at least one new contribution skills PR touches skills awaiting-automation merge-risk:medium labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Adds 3 file(s), e.g. skills/what-breaks-in-ai-code/SKILL.md
  • Changes 238 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for ef904b6 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 3 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ what-breaks-in-ai-code (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/what-breaks-in-ai-code
✅ what-breaks-in-ai-code (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 3, 2026
@aaronpowell aaronpowell closed this Nov 4, 2026
@aaronpowell

Copy link
Copy Markdown
Contributor

The source repository linked from this PR promotes the paid Product Audit at https://agensi.io/r/ADAMREEL?to=/skills/product-audit alongside its free review material. That makes this a lead-in to an author-owned paid review product rather than an independent community contribution, so we can’t accept it as submitted.

@aaronpowell aaronpowell mentioned this pull request Nov 4, 2026
9 of 17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium new-submission PR adds at least one new contribution ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants