rust: forward intercepted HTTP via hyper+native-tls to drop ring#1973
Open
Shivam60 wants to merge 5 commits into
Open
rust: forward intercepted HTTP via hyper+native-tls to drop ring#1973Shivam60 wants to merge 5 commits into
Shivam60 wants to merge 5 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Two fixes so this actually drops ring and passes CI: - Commit the regenerated Cargo.lock. Cargo.toml had already moved off reqwest to the hyper stack, but the lockfile was not updated, so ring/rustls/reqwest were still locked (the whole point is to remove them) and the lock was out of sync with the manifest, failing the Rust test jobs. Regenerating removes ring, rustls, hyper-rustls, tokio-rustls and untrusted. - Rewrite OAuthMcpServer::requests over the hyper-util legacy Client. The previous version called hyper::body::to_bytes, which no longer exists in hyper 1.x, and had trailing whitespace that failed cargo fmt --check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
stephentoub
reviewed
Jul 13, 2026
stephentoub
left a comment
stephentoub
left a comment
Collaborator
There was a problem hiding this comment.
Does this no longer respect proxy configuration, e.g. HTTP_PROXY, HTTPS_PROXY, and NO_PROXY?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqwest (forward_http) pins rustls/hyper-rustls optionals in Cargo.lock, dragging in ring (CG High, MVS-2022-374v-6mvc) even though only native-TLS is used and ring is never compiled. Replace reqwest with its underlying hyper+hyper-tls native-TLS stack (native-tls ALPN preserves HTTP/2). Removes ring/rustls entirely; all tests pass, clippy clean.