[Java] Clean-up: make it so interim time during implementation produces correct artifacts - #2345
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
Restricts Java native-runtime packaging to supported build hosts so incorrect platform-classified artifacts are not produced.
Changes:
- Adds host-activated Maven native packaging.
- Updates native-build documentation and ADR.
- Adds temporary implementation and validation plans.
Show a summary per file
| File | Description |
|---|---|
java/copilot-native/pom.xml |
Adds host-gated native packaging profiles. |
java/README.md |
Documents native build behavior. |
java/docs/adr/adr-007-native-bundling-strategy.md |
Records the host-matched packaging strategy. |
2323-java-windows-x64-embed-rust-remove-before-merge/20260815-make-it-so-no-incorrect-os-arch-artifacts-are-produced.md |
Adds a temporary implementation plan. |
2323-java-windows-x64-embed-rust-remove-before-merge/20260816-notes-to-linux-x64-agent.md |
Adds a temporary Linux validation handoff. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Balanced
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2ea248b2-112a-4548-865e-922721479b0c
edburns
force-pushed
the
edburns/2323-java-windows-x64-embed-rust
branch
from
August 24, 2026 18:47
84a429b to
c5c8e28
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: de80978a-085e-476a-97a2-d2c5858446f6 fix(java): guard native packaging by libc Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: de80978a-085e-476a-97a2-d2c5858446f6 Remove prompts before merge
edburns
force-pushed
the
edburns/2323-java-windows-x64-embed-rust
branch
from
August 24, 2026 21:40
c5c8e28 to
a3316cc
Compare
Contributor
Cross-SDK Consistency Review ✅This PR is entirely scoped to the Java SDK's native bundling infrastructure — no public SDK API surface is added or modified. Changed files:
Consistency assessment: The fix corrects incorrect No cross-language consistency issues found. 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2344 .
Since the merging of #2301 , the Java Maven POM incorrectly produced artifacts containing
linux-x64in the filename, regardless of the actual os-arch of the build. This is incorrect. The correct behavior is to make it so only when the actual os-arch islinux-x64should such artifacts be produced.