Repository navigation
Fix allowed contexts for reusable workflow secrets/inputs - #40392
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes inconsistencies in the allowed contexts documentation for reusable workflow secrets and inputs in the contexts reference. It updates the allowed contexts for jobs.<job_id>.secrets.<secret_id> and jobs.<job_id>.with.<input_id> to match their actual behavior and align with the documentation in reusable-workflows.md.
Key changes:
- Removes
vars,inputs,strategy, andmatrixfrom allowed contexts for workflow secrets and inputs - Renames parameter placeholders for consistency:
<secrets_id>to<secret_id>and<with_id>to<input_id>
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
2883ead to
dac15a9
Compare
|
Following new testing, this PR has been updated to consider the allowed expression contexts from |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
Yes, this is still relevant to this day. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
mchammer01
left a comment
There was a problem hiding this comment.
Nice catch on the placeholder naming and the missing contexts. Verified against the parser and this all checks out ✨
LGTM ![]()
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #40391
What's being changed (if available, include any code snippets, screenshots, or gifs):
This updates the allowed contexts for
jobs.<job_id>.secrets.<secret_id>andjobs.<job_id>.with.<input_id>inreusable-workflows.mdto match the actual behavior and the documentation incontexts.md. This addsstrategy,matrix,inputs, andvarsto the allowed contexts for these keys, ensuring consistency.This also renames placeholders in workflow keys in
contexts.mdto match those used inreusable-workflows.md, replacing<secrets_id>with<secret_id>and<with_id>with<input_id>for consistency.Please verify that these changes are correct and align with the intended functionality and actual behavior of GitHub Actions.
Check off the following: