Skip to content

Run Node.js CI for pull requests - #77

Merged
liuliu-dev merged 1 commit into
mainfrom
fix/run-ci-for-pull-requests
Oct 20, 2026
Merged

liuliu-dev merged 1 commit into
mainfrom
fix/run-ci-for-pull-requests

Conversation

@liuliu-dev

Copy link
Copy Markdown
Contributor

Summary

  • Run the existing Node.js CI workflow on pull_request as well as push.
  • Preserve the existing build, tests, Node version, and read-only job permissions.

Why

PR #76 has no Node.js CI run because the workflow only listens for pushes to this repository. A push to a contributor's fork does not trigger the upstream workflow, leaving the required build check missing.

After this change merges, update the branch for #76 (or reopen it) to trigger its pull-request build.

Validation

  • Verified the remote commit changes exactly one line in the workflow and leaves all job steps unchanged.
  • GitHub Actions on this PR will validate the existing build and tests; no local checkout was used.

Keep push builds and run the same build job for pull requests, including contributions from forks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 20, 2026 19:04
@liuliu-dev
liuliu-dev requested a review from a team as a code owner October 20, 2026 19:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The trigger-only change enables PR validation without altering existing job behavior or permissions.

No open issues 🎉

What changed in this PR

Enables upstream Node.js CI for pull requests, including fork contributions such as #76.

Changes:

  • Adds pull_request alongside the existing push trigger.
  • Preserves the build, tests, Node version, and read-only job permissions.
File Description
.github/​workflows/​nodejs.yml Enables pull-request CI runs.

Review effort: Max

@liuliu-dev
liuliu-dev merged commit cbaeee4 into main Oct 20, 2026
8 checks passed
@liuliu-dev
liuliu-dev deleted the fix/run-ci-for-pull-requests branch October 20, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants