Unify job-name normalizers and split grab-bag stringutil.go by Copilot · Pull Request #54702 · github/gh-aw

Copilot · 2026-08-22T02:59:40Z

Three call sites reimplemented job-name normalization independently and disagreed on canonical form (hyphen vs. underscore), and stringutil.go had become a grab-bag file mixing unrelated concerns.

Canonical hyphen-form normalizer

Added stringutil.NormalizeIdentifierToHyphens, the hyphen-canonical counterpart to the existing NormalizeSafeOutputIdentifier (underscore-canonical), converting _ and . to -.
Documented, tested (unit + spec test), and added to the package README following existing conventions.

Collapsed divergent call sites onto canonical helpers

sanitizeJobName (pkg/workflow/strings.go) previously round-tripped through NormalizeSafeOutputIdentifier and immediately undid it — now calls NormalizeIdentifierToHyphens directly:
```
func sanitizeJobName(workflowName string) string {
    return stringutil.NormalizeIdentifierToHyphens(workflowName)
}
```
normalizeMaintenanceJobName (pkg/workflow/repo_config.go) now delegates its separator normalization to NormalizeIdentifierToHyphens after lowercasing/trimming.
normalizeJobName (pkg/cli/logs_report.go) now delegates to NormalizeSafeOutputIdentifier after lowercasing/trimming/space-handling.
Known maintenance job names never contain periods, so the added period handling is not a behavior change for supported inputs (documented at the call site).

Split `stringutil.go` grab-bag

whitespace.go: NormalizeWhitespace, NormalizeLeadingWhitespace
version.go: ParseVersionValue
stringutil.go: now only Truncate, FormatList, IsPositiveInteger
Corresponding tests moved alongside their functions; README updated to reflect the new file organization.

Fixes [refactor] stringutil/stats: divergent job-name normalizers and grab-bag stringutil.go #54695

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.3 AIC · ⌖ 8.33 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…eJobName Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-22T03:16:26Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-22T03:16:28Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-22T03:16:31Z

❌ Design Decision Gate 🏗️ failed during design decision gate check.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-22T03:16:31Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-22T03:16:33Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #54702

github-actions · 2026-08-22T03:20:46Z

Comment Memory

reviewed_at: 2026-08-22T03:18:39Z
review_event: REQUEST_CHANGES
top_themes:
  - behavior change in dotted job-name normalization without compatibility coverage
  - missing workflow-level tests for generated job IDs after canonicalization change
files_reviewed:
  - pkg/cli/logs_report.go
  - pkg/stringutil/README.md
  - pkg/stringutil/identifiers.go
  - pkg/stringutil/identifiers_test.go
  - pkg/stringutil/spec_test.go
  - pkg/stringutil/stringutil.go
  - pkg/stringutil/stringutil_test.go
  - pkg/stringutil/version.go
  - pkg/stringutil/version_test.go
  - pkg/stringutil/whitespace.go
  - pkg/stringutil/whitespace_test.go
  - pkg/workflow/repo_config.go
  - pkg/workflow/strings.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 28.6 AIC · ⌖ 10.2 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

github-actions

Requesting changes

This refactor changes job-name normalization semantics without proving the new . handling is safe for existing workflow names, and there are no workflow-level tests covering that compatibility boundary.

Blocking themes

sanitizeJobName and maintenance-job normalization now rewrite periods to hyphens, which is a behavior change for any existing dotted identifiers.
The PR adds unit/spec tests for the helper itself but does not add an end-to-end compiler test showing dotted workflow names still resolve correctly through generated job IDs and references.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 28.6 AIC · ⌖ 10.2 AIC · ⊞ 7K
_{Comment /review to run again}

Copilot

Pull request overview

This PR centralizes job-name separator normalization and reorganizes stringutil into focused modules without changing existing utility behavior.

Changes:

Adds and tests hyphen-canonical identifier normalization.
Updates three job-name normalization call sites to use shared helpers.
Moves whitespace and version utilities into dedicated files.

Show a summary per file

File	Description
`pkg/workflow/strings.go`	Uses the hyphen normalizer for job names.
`pkg/workflow/repo_config.go`	Centralizes maintenance job normalization.
`pkg/cli/logs_report.go`	Uses canonical safe-output normalization.
`pkg/stringutil/identifiers.go`	Adds the hyphen-canonical helper.
`pkg/stringutil/identifiers_test.go`	Tests and benchmarks the new helper.
`pkg/stringutil/spec_test.go`	Adds public API specification coverage.
`pkg/stringutil/whitespace.go`	Houses whitespace normalization utilities.
`pkg/stringutil/whitespace_test.go`	Moves corresponding tests and benchmarks.
`pkg/stringutil/version.go`	Houses version-value coercion.
`pkg/stringutil/version_test.go`	Moves version coercion tests.
`pkg/stringutil/stringutil.go`	Retains general-purpose helpers.
`pkg/stringutil/stringutil_test.go`	Removes tests relocated with their implementations.
`pkg/stringutil/README.md`	Documents the new helper and file organization.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 13/13 changed files
Comments generated: 0
Review effort level: Balanced

github-actions

Skills-Based Review 🧠

Applied /codebase-design — requesting minor changes on two navigability issues left by the refactor.

📋 Key Themes & Highlights

Key Themes

Stale inline comment (compiler_safe_output_jobs.go:194): describes the old two-step implementation; should be updated to match the new direct delegation
Incomplete doc catalogue (strings.go:36): the "Normalize Pattern" registry doesn't list NormalizeIdentifierToHyphens, which is now used in the same file

Positive Highlights

✅ Clean elimination of three divergent reimplementations — the canonical NormalizeIdentifierToHyphens is a well-named, well-documented deep module
✅ Excellent test coverage: unit tests, spec tests, and benchmarks all added for the new function
✅ sanitizeJobName is now a single, intention-revealing line — a clear win
✅ README updated and file split into focused concerns — highly navigable

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 52.1 AIC · ⌖ 11 AIC · ⊞ 7.6K
_{Comment /matt to run again}

Comments that could not be inline-anchored

pkg/workflow/strings.go:36

[/codebase-design] The "Normalize Pattern" doc block at line ~36 lists only NormalizeSafeOutputIdentifier as a normalize helper, but sanitizeJobName in this same file now delegates to NormalizeIdentifierToHyphens. The registry is incomplete after the refactor.

<details>
<summary>💡 Suggested fix</summary>

Add the new function to the list:

//   - stringutil.NormalizeIdentifierToHyphens: Converts underscores/periods to hyphens (job names)

Keeping the catalogue accurate is …

github-actions

Clean refactoring. The behavioral equivalence between old and new paths is correct:

sanitizeJobName: the old two-step (NormalizeSafeOutputIdentifier → underscores, then _→-) is exactly equivalent to the new single-step NormalizeIdentifierToHyphens (. and _ → -). ✅
normalizeJobName: now also replaces . with _ via NormalizeSafeOutputIdentifier, a harmless expansion since GitHub Actions job names do not use periods. ✅

The file split is well-structured and the new function is properly documented and tested.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 42.5 AIC · ⌖ 8.97 AIC · ⊞ 6.2K

gh-aw-bot · 2026-08-22T05:10:29Z

@copilot this PR still needs forward progress before maintainer review.

Unresolved review feedback remains around the job-name normalization behavior change and missing compatibility coverage/tests.
Failed checks on the current head:
- impacted-go-tests: https://github.com/github/gh-aw/actions/runs/32553156875/job/96983075295
- lint-go-custom: https://github.com/github/gh-aw/actions/runs/32553156875/job/96983075476
Please address the outstanding review points, rerun the focused validations for the touched workflow/stringutil paths, refresh the branch if needed, and run the pr-finisher skill.

Run: https://github.com/github/gh-aw/actions/runs/32553383419

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.3 AIC · ⌖ 8.33 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-22T05:31:05Z

@copilot this PR still needs forward progress before maintainer review.

Unresolved review feedback remains around the job-name normalization behavior change and missing compatibility coverage/tests...

Addressed in 0bbbd5d: restored period-preserving matching where separators are not equivalent, added dotted workflow compiler coverage for generated job IDs, conditions, and paths, and updated normalization documentation. Focused packages and the repository lint/test/recompile pass completed; the prior impacted-test failure was a missing origin/main merge-base and custom-lint failures are pre-existing diagnostics outside this PR.

github-actions · 2026-08-22T06:27:34Z

PR Triage

Category: refactor
Risk: medium
Priority score: 38/100 (impact 10, urgency 20, quality 8)
Recommended action: batch_review
CI status: failing
Batch: batch-1

Generated by 🔧 PR Triage Agent · auto · 82.9 AIC · ⌖ 6.65 AIC · ⊞ 8.3K · ◷

Initial plan

0bc53d1

Copilot AI assigned Copilot and pelikhan Aug 22, 2026

Copilot started work on behalf of pelikhan August 22, 2026 02:59 View session

Copilot AI linked an issue Aug 22, 2026 that may be closed by this pull request

[refactor] stringutil/stats: divergent job-name normalizers and grab-bag stringutil.go #54695

Open

4 tasks

Copilot AI and others added 2 commits August 22, 2026 03:12

Add hyphen-form identifier normalizer; split stringutil.go grab-bag file

1e15c0e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Document non-behavior-changing period handling in normalizeMaintenanc…

3fa40b0

…eJobName Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor string utility job-name normalizers~~ Unify job-name normalizers and split grab-bag stringutil.go Aug 22, 2026

Copilot finished work on behalf of pelikhan August 22, 2026 03:14

Copilot AI requested a review from pelikhan August 22, 2026 03:14

pelikhan marked this pull request as ready for review August 22, 2026 03:15

Copilot AI balanced review requested due to automatic review settings August 22, 2026 03:15

Copilot started reviewing on behalf of pelikhan August 22, 2026 03:15 View session

github-actions Bot requested changes Aug 22, 2026

View reviewed changes

Copilot AI reviewed Aug 22, 2026

View reviewed changes

github-actions Bot requested changes Aug 22, 2026

View reviewed changes

github-actions Bot approved these changes Aug 22, 2026

View reviewed changes

github-actions Bot added the needs-review label Aug 22, 2026

github-actions Bot mentioned this pull request Aug 22, 2026

[pr-sous-chef] PR Sous Chef run report #54661

Open

Merge branch 'main' into copilot/refactor-stringutil-stats

c7bfe4d

Copilot started work on behalf of gh-aw-bot August 22, 2026 05:10 View session

Preserve dotted job-name compatibility

f18bb53

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 22, 2026 05:31

Copilot AI requested a review from gh-aw-bot August 22, 2026 05:31

github-actions Bot added pr-action:batch_review pr-agent:copilot pr-batch:batch-1 pr-priority:medium pr-risk:medium pr-type:refactor labels Aug 22, 2026

github-actions Bot mentioned this pull request Aug 22, 2026

[PR Triage Report] PR Triage Report — 2026-08-22 (Run 32556532240) #54751

Open

Navigation Menu

Uh oh!

Unify job-name normalizers and split grab-bag stringutil.go - #54702

Unify job-name normalizers and split grab-bag stringutil.go#54702
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/refactor-stringutil-stats

Copilot AI commented Aug 22, 2026 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 22, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

gh-aw-bot commented Aug 22, 2026

Uh oh!

Copilot AI commented Aug 22, 2026

Uh oh!

github-actions Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Aug 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Canonical hyphen-form normalizer

Collapsed divergent call sites onto canonical helpers

Split stringutil.go grab-bag

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Requesting changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Comments that could not be inline-anchored

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 22, 2026

Uh oh!

Copilot AI commented Aug 22, 2026

Uh oh!

github-actions Bot commented Aug 22, 2026

PR Triage

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 22, 2026 •

edited by github-actions Bot

Loading

Split `stringutil.go` grab-bag

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading