Open
Refactor GitHub MCP transport options to share a single common option struct#54714
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Copilot Request
Refactor GitHub MCP transport options to share a single common option struct
Aug 22, 2026
Contributor
PR Triage
|
Contributor
PR TriageCategory: Draft. Consolidates GitHub MCP transport option structs. Automated triage — run 32572524009
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHubMCPDockerOptionsandGitHubMCPRemoteOptionshad re-diverged, each redeclaring the same 8 shared fields. This change consolidates those fields into one embeddedGitHubMCPCommonOptionsto keep shared MCP behavior aligned across transport modes.Shared option model
GitHubMCPCommonOptionswith:ReadOnly,Lockdown,LockdownFromStep,GuardPoliciesFromStepToolsets,Features,AllowedTools,GuardPoliciesGitHubMCPDockerOptionsandGitHubMCPRemoteOptionsto embed the common struct.Renderer construction updates
mcp_renderer_github.goto initialize shared fields viaGitHubMCPCommonOptions, leaving transport-specific fields in the transport structs.Test alignment + regression guard
GitHubMCPCommonOptions.