Skip to content

Add accessible name to docs home logo link - #54748

Merged
pelikhan merged 3 commits into
mainfrom
copilot/fix-logo-accessibility-issue
Aug 22, 2026
Merged

Add accessible name to docs home logo link#54748
pelikhan merged 3 commits into
mainfrom
copilot/fix-logo-accessibility-issue

Conversation

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Mobile and tablet layouts hide the visible site title text, leaving the home/logo link without a usable accessible name. This made the primary docs home link ambiguous for assistive technology users on narrow viewports.

  • Header accessibility
    • Added a stable accessible name to the docs site-title home link.
    • Marked the nested logo image as decorative to avoid duplicate announcements.
<a href={homeUrl} class="site-title" aria-label="GitHub Agentic Workflows home">
  <img src={initialLogoUrl} alt="" class="theme-logo" />
  <span>GitHub Agentic Workflows</span>
</a>
  • Regression coverage
    • Added a focused Playwright check that verifies the mobile home logo link exposes the expected accessible name.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

  • Category: chore
  • Risk: low
  • Priority score: 30/100 (impact 10, urgency 5, quality 15)
  • Recommended action: defer
  • CI status: pending

Generated by 🔧 PR Triage Agent · auto · 82.9 AIC · ⌖ 6.65 AIC · ⊞ 8.3K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix accessible name for logo link on mobile and tablet views Add accessible name to docs home logo link Aug 22, 2026
Copilot AI requested a review from pelikhan August 22, 2026 06:31
@github-actions

Copy link
Copy Markdown
Contributor

Nice accessibility fix! 👍 This adds a stable aria-label to the docs site-title home link and marks the nested logo image as decorative, resolving an ambiguous accessible name on narrow/mobile viewports (fixes #54740).

Coverage:

  • ✅ Focused, minimal change (2 files, 13 lines)
  • ✅ Regression coverage — a focused Playwright test verifies the mobile home logo link exposes the expected accessible name
  • ✅ Clear description with rationale and code excerpt

This looks ready for review. 🟢

Generated by ✅ Contribution Check · auto · 51 AIC · ⌖ 5.08 AIC · ⊞ 9.2K ·

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

Category: bug | Risk: low | Priority: low | Score: 30/100
Recommended action: defer

Draft. Accessibility fix for docs logo link. Tiny (11/2, 2 files).

Automated triage — run 32572524009

Generated by 🔧 PR Triage Agent · auto · 65.4 AIC · ⌖ 6.04 AIC · ⊞ 8.3K ·

@pelikhan
pelikhan marked this pull request as ready for review August 22, 2026 12:41
Copilot AI balanced review requested due to automatic review settings August 22, 2026 12:41
@pelikhan
pelikhan merged commit 2c699b9 into main Aug 22, 2026
@pelikhan
pelikhan deleted the copilot/fix-logo-accessibility-issue branch August 22, 2026 12:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a stable accessible name to the responsive documentation home link.

Changes:

  • Labels the home link and marks its logo decorative.
  • Adds mobile Playwright regression coverage.
Show a summary per file
File Description
docs/src/components/CustomLogo.astro Improves the home link’s accessible name.
docs/tests/site-title-accessibility.spec.ts Verifies the accessible name on mobile.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔍 Multi-Device Docs Testing Report - 2026-08-22

3 participants