Split safe-output handler registry by category - #55501
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Splits the monolithic safe-output registry into focused category registries without changing handler behavior.
Changes:
- Organizes all 50 handlers across five category files.
- Extracts shared token-resolution helpers.
- Adds coverage for missing, duplicate, and unexpected registrations.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/safe_outputs_handler_registry.go |
Assembles category registries. |
pkg/workflow/safe_outputs_handler_tokens.go |
Contains shared token helpers. |
pkg/workflow/safe_outputs_handler_registry_test.go |
Verifies complete, unique registration. |
pkg/workflow/safe_outputs_handler_registry_issues.go |
Registers issue and discussion handlers. |
pkg/workflow/safe_outputs_handler_registry_pull_requests.go |
Registers pull-request handlers. |
pkg/workflow/safe_outputs_handler_registry_automation.go |
Registers repository automation handlers. |
pkg/workflow/safe_outputs_handler_registry_dispatch.go |
Registers dispatch and reporting handlers. |
pkg/workflow/safe_outputs_handler_registry_artifacts_projects.go |
Registers artifact and project handlers. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Balanced
|
@copilot Please review the latest PR state, refresh the branch if needed, and run the
|
…plit-safe-outputs-handler # Conflicts: # pkg/workflow/safe_outputs_handler_registry.go # pkg/workflow/safe_outputs_handler_registry_issues.go # pkg/workflow/safe_outputs_handler_registry_pull_requests.go # pkg/workflow/safe_outputs_handler_registry_test.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Merged |
|
🎉 This pull request is included in a new release. Release: |
The 1,091-line safe-output handler registry combined 50 inline handlers in one map, making reviews and concurrent changes unnecessarily difficult.
Registry organization
Regression coverage