[compiler-threat-spec] Add CTR-027: pre-created PR branch confusion to threat detection spec

[github-actions]

Daily Compiler Threat Spec Optimizer — 2026-08-25

View Details

Threats reviewed: All compiler/parser/actions/setup/js changes merged since the 1.0.26 audit (last ~2 days), including #55532, #55529, #55481, #55496, #55482, #55480, #55518, #55522, and the [test-parallel]/[dead-code] batches.

Covered → added to spec:

• CTR-027 Pre-Created Pull Request Branch Confusion (new rule, was implemented-but-undocumented): Validate pre-created PR branch before privileged checkout #55481 added a validate-pre-created-pull-request activation-job step that re-derives the expected pre-created branch ref (<branch-prefix><run_id>-<run_attempt>) and rejects any mismatch before privileged agent/safe-outputs checkout, validates the PR number format, and confirms via the GitHub API that head.repo/base.repo match the trusted current repository — closing a branch-confusion/cross-fork redirection gap. Also covers the new static/valid-git-ref-prefix validation for branch-prefix.
  • Test ID: T-CTR-042
  • Implementation: pkg/workflow/compiler_precreate_pull_request.go, pkg/workflow/create_pull_request.go, actions/setup/js/validate_pre_created_pull_request.cjs
  • Tests: pkg/workflow/compiler_precreate_pull_request_test.go, pkg/workflow/compiler_precreate_pull_request_integration_test.go, actions/setup/js/validate_pre_created_pull_request.test.cjs

No implementation required — reviewed and confirmed out of scope or already covered by existing rules:

• Pipe threat-detection kill-switch frontmatter into compiled threat-detect invocation #55532 (threat-detect kill-switch flags engine-timeout/max-turns/retries) — operational governance for detector tooling, not a security boundary; ordinary schema validation already rejects invalid values.
• Fix conclusion job issues permission derivation #55529 (conclusion job issues: write derivation fix) — correctness fix within existing CTR-001 permissions scope.
• Split pkg/workflow/awf_config.go into types / schema / build / policy files #55496, Split safe outputs handler registry by domain #55482 — internal file-organization refactors, no behavior change.
• Guard allocation size calculations flagged by CodeQL #55480 — defensive overflow guard, not attacker-reachable via frontmatter.
• Deduplicate token-usage and integrity-level types flagged by Typist #55518, Improve test coverage and assertions in pkg/cli/logs_firewall_parse_test.go #55522 — type dedup / test-assertion hardening, no detection-logic change.
• [test-parallel] / [dead-code] batches — test-only / dead-code removal.

Rule IDs added: CTR-027 (new), test ID T-CTR-042.

Files changed: specs/compiler-threat-detection-spec.md (Section 2 sync table, Section 5.1 rule catalog, Section 7.1 implementation mapping, Section 8.1 test catalog, Section 10 changelog; version bumped 1.0.26 → 1.0.27).

Tests run: None (documentation-only spec update; no compiler/parser source changed).

Suppression review: No threat-detection-suppress annotations found in live workflow sources this cycle — no SLA_BREACH or expiration findings.

Generated by 🔒 Daily Compiler Threat Spec Optimizer · copilot · auto · 100.2 AIC · ⌖ 7.76 AIC · ⊞ 8.3K · ◷

• expires on Aug 31, 2026, 6:53 PM UTC-08:00