Repository navigation
Accept submission metadata in work queue delivery verification - #75384
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change supporting submission metadata in work-queue delivery verification.
No open issues 🎉
What changed in this PR
Fixes #75274 by allowing submission metadata in gh-aw’s work-queue delivery verification, preventing successfully created pull requests and discussions from leaving delivery pending and blocking dependent Works.
Changes:
- Accepts
output_idanddepends-onin native creation and shared built-in verifiers. - Preserves undeclared-field rejection and existing readback checks.
- Expands regression coverage for metadata combinations, verified Work finalization, and unrelated-field rejection.
| File | Description |
|---|---|
actions/setup/js/work_queue_native_creation_delivery.test.cjs |
Tests metadata acceptance, Work finalization, and undeclared-field rejection. |
actions/setup/js/work_queue_native_creation_delivery.cjs |
Allows both metadata fields during native creation verification. |
actions/setup/js/work_queue_delivery.test.cjs |
Exercises shared delivery verification with metadata combinations. |
actions/setup/js/work_queue_delivery.cjs |
Adds both metadata fields to the shared built-in allowlist. |
Review effort: Balanced (auto)
|
🎉 This pull request is included in a new release. Release: |
Automatically added
output_idcaused queue-bound PR and discussion creation to fail delivery verification, leaving delivery pending and blocking dependent Works.depends-ontriggered the same rejection.