Skip to content

Accept submission metadata in work queue delivery verification - #75384

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-verify-output-id
Nov 6, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/fix-verify-output-id

Conversation

Copilot AI commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Automatically added output_id caused queue-bound PR and discussion creation to fail delivery verification, leaving delivery pending and blocking dependent Works. depends-on triggered the same rejection.

  • Verification: Allow both metadata fields in native creation and shared built-in delivery verifiers; retain undeclared-field rejection and existing readback checks.
  • Regression coverage: Cover metadata individually and together, verified Work finalization, and continued rejection of unrelated fields.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix work queue delivery verification for output_id Accept submission metadata in work queue delivery verification Nov 6, 2026
Copilot AI requested a review from pelikhan November 6, 2026 09:07
@pelikhan
pelikhan marked this pull request as ready for review November 6, 2026 13:59
Copilot AI auto review requested due to automatic review settings November 6, 2026 13:59
@pelikhan
pelikhan merged commit 8bb82a7 into main Nov 6, 2026
42 checks passed
@pelikhan
pelikhan deleted the copilot/fix-verify-output-id branch November 6, 2026 13:59
Copilot stopped reviewing on behalf of pelikhan due to an error November 6, 2026 13:59
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~1 AIC · ⌖ ~1 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #75384

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: opus55 medium · ~11 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~1 AIC · ⌖ ~1 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~2 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #75384

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change supporting submission metadata in work-queue delivery verification.

No open issues 🎉

What changed in this PR

Fixes #75274 by allowing submission metadata in gh-aw’s work-queue delivery verification, preventing successfully created pull requests and discussions from leaving delivery pending and blocking dependent Works.

Changes:

  • Accepts output_id and depends-on in native creation and shared built-in verifiers.
  • Preserves undeclared-field rejection and existing readback checks.
  • Expands regression coverage for metadata combinations, verified Work finalization, and unrelated-field rejection.
File Description
actions/​setup/​js/​work_queue_native_creation_delivery.test.cjs Tests metadata acceptance, Work finalization, and undeclared-field rejection.
actions/​setup/​js/​work_queue_native_creation_delivery.cjs Allows both metadata fields during native creation verification.
actions/​setup/​js/​work_queue_delivery.test.cjs Exercises shared delivery verification with metadata combinations.
actions/​setup/​js/​work_queue_delivery.cjs Adds both metadata fields to the shared built-in allowlist.

Review effort: Balanced (auto)

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Work queue: create_pull_request/create_discussion delivery never verifies because output_id isn't an allowed message field

3 participants