Skip to content

[instructions] Sync instruction files with release 1.0.1 - #75642

Merged
pelikhan merged 1 commit into
mainfrom
instructions-janitor/sync-v1.0.1-2026-11-07-edd50006ed590eb2
Nov 7, 2026
Merged

pelikhan merged 1 commit into
mainfrom
instructions-janitor/sync-v1.0.1-2026-11-07-edd50006ed590eb2

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Threat detection engine error

Threat detection could not complete its analysis due to a tooling error. This is not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs to troubleshoot the error.

Overview

This PR updates .github/aw/ instruction files for four user-facing features merged after release v1.0.1. These features are already in docs/ and main_workflow_schema.json, but the instruction files did not cover them. All instruction files are within the 400-line limit.

Changes

File Change Lines (before → after)
safe-outputs-content.md Adds create-issue options deduplicate-by-labels, max-issue-artifacts, and max-issue-artifact-size, plus a short note on the artifacts runtime field that links to the docs reference 391 → 396
memory.md Adds repo-memory GitHub App auth (github-app, github-app-read, github-app-write) for ruleset-protected memory branches 359 → 361
syntax-core.md Adds the object form of environment: (name, url, deployment), including deployment: false 175 → 175

Audit results

  • Release/change audit: The latest release is v1.0.1 (2026-10-27). The checkout is shallow, so the release tag can't be resolved locally. I listed commits through the GitHub API instead and checked the changes after the last instructions sync ([instructions] Sync instruction files with release 1.0.1 #75371).
  • Size audit: Every .github/aw/*.md file is ≤ 400 lines. cli-commands.md is exactly 400 and safe-outputs-content.md is now 396. Both are near the limit and should get a dedicated sub-file before more content is added.
  • Duplication audit: This PR adds no duplication. Issue-artifact detail stays in the docs reference; the instructions keep only a short summary and a link.
  • Accuracy audit: I checked the new fields against pkg/parser/schemas/main_workflow_schema.json (max-issue-artifacts, max-issue-artifact-size, deduplicate-by-labels, github-app-read/github-app-write, environment.deployment).
Documentation commits reviewed

Validation

  • No Go or .github/workflows/*.md files changed, so I didn't run make fmt or make recompile.
  • I didn't run the make agent-report-progress gates either. This workflow only allows Bash for the audit and git commands.
  • The steering issue [WIP] Instructions Janitor: work in progress #75641 had no steer comments.

Next actions

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 🧹 Instructions Janitor · claude · routed: opus55 medium · ~101 AIC · ⌖ ~2 AIC · ⊞ 3.2K · ◷

  • expires on Nov 9, 2026, 12:35 AM UTC-08:00

…ory app auth, environment deployment

Sync .github/aw with #75323, #74941, #74937, and #74938.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documentation contains two active inaccuracies about label filtering and the issue-creation validation guarantee that need correction.

2 open issues
What changed in this PR

This pull request updates .github/aw/ instruction files to document features introduced after release v1.0.1, aligning agent guidance with the current schema and runtime behavior.

Changes:

  • Documents create-issue label deduplication, artifact limits, and artifact inputs.
  • Adds GitHub App authentication guidance for protected repo-memory branches.
  • Documents object-form environments and deployment: false.
File Summary Review notes
.github/​aw/​syntax-core.md Documents object-form environment configuration and deployment suppression. Nits: Clarify that only name is required, while url and deployment are optional; include expression support for deployment. Update the safe-output runtime guidance, which still describes environment as string-only.
.github/​aw/​safe-outputs-content.md Adds issue deduplication, artifact limits, and artifact usage guidance. Nits: Clarify that label filtering works independently of title deduplication; present size formats as examples rather than an exhaustive list; narrow the pre-creation validation guarantee and mention possible post-creation partial failures.
.github/​aw/​memory.md Adds GitHub App authentication guidance for repo-memory reads and writes. Nit: Specify the distinct Contents permissions required by github-app-read and github-app-write.

Review effort: Lite (auto)

Comment thread .github/aw/safe-outputs-content.md Resolved
Comment thread .github/aw/safe-outputs-content.md Resolved
@pelikhan
pelikhan merged commit 140d125 into main Nov 7, 2026
3 checks passed
@pelikhan
pelikhan deleted the instructions-janitor/sync-v1.0.1-2026-11-07-edd50006ed590eb2 branch November 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants