fix: make converge coverage auditable - #3754
cadugevaerd wants to merge 1 commit into
Conversation
Require artifact-derived per-category coverage, expose stable inventory keys, and fail closed before appending tasks when assessment is incomplete. Closes github#3752 Assisted-by: Hermes Agent (model: gpt-5.6-terra, autonomous)
There was a problem hiding this comment.
Pull request overview
Adds auditable convergence coverage and fail-closed handling for incomplete assessments.
Changes:
- Adds per-category coverage metrics and stable-key ledgers.
- Introduces
incomplete_assessment. - Documents and tests all three outcomes.
Show a summary per file
| File | Description |
|---|---|
templates/commands/converge.md |
Defines coverage, ledger, and outcome rules. |
docs/reference/agentic-sdd.md |
Documents the new outcome contract. |
tests/test_converge_template_contract.py |
Adds template regression tests. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Medium
| - Buildable SCs checked: `<checked>/<total>` | ||
| - Acceptance scenarios checked: `<checked>/<total>` | ||
| - Plan decisions checked: `<checked>/<total>` | ||
| - Constitution MUST principles checked: `<checked>/<total>` (or `skipped — template`) |
| "Constitution MUST principles checked: `<checked>/<total>`", | ||
| ): | ||
| assert metric in content | ||
|
|
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Please address Copilot feedback
|
Thanks for the fix. The overall approach looks right, but the two existing inline review comments still need to be addressed before approval. Could you please update the PR by August 5, or let us know if you are unavailable? If there is no response by then, a maintainer can take over the small follow-up changes so the high-severity issue keeps moving. Posted on behalf of @BenBtg by GitHub Copilot (model: GPT-5.6 Sol). |
|
This pull request has been automatically marked as stale because it has had no activity for 60 days. It will be closed in 30 days unless there is a substantive update. If you intend to continue, please describe the current status, address or acknowledge outstanding feedback, and confirm whether the branch can be updated and the change remains ready for review. A comment that only states that the pull request is "still relevant" does not provide enough context for maintainers. |
Summary
/speckit.convergeemit artifact-derivedchecked/totalcoverage per category and a stable-key ledgerincomplete_assessmentbefore appending tasks when any required key is unassessedValidation
python -m pytest tests -q— 5438 passed, 7 skippedmarkdownlint-cli2 templates/commands/converge.md docs/reference/agentic-sdd.md— 0 issuesincomplete_assessment,tasks_appended, andconvergedpaths; the final converged pass lefttasks.mdunchangedCloses #3752