Skip to content

fix: use logger instead of print() in events.py #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: use logger instead of print() in events.py #3965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
795d46e
fix: use logger instead of print() for error/warning messages in even…
Quratulain-bilal Aug 3, 2026
5e63f35
Merge remote-tracking branch 'origin/main' into fix/events-use-logger
Quratulain-bilal Oct 2, 2026
91effd5
fix(events): retarget the logger conversion after the events package …
Quratulain-bilal Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/specify_cli/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,10 @@ def _run_inline(command_name, payload, project_root, timeout, envelope="plain",
return result.returncode
return 0
except subprocess.TimeoutExpired:
print(f"Event {command_name} timed out", file=sys.stderr)
logger.error("Event %s timed out", command_name)
return 2
except Exception as e:
print(f"Event {command_name} error: {e}", file=sys.stderr)
logger.error("Event %s error: %s", command_name, e)
Comment thread
Quratulain-bilal marked this conversation as resolved.
return 2


Expand Down Expand Up @@ -1371,9 +1371,8 @@ def install_integration_events(
if ev in canonical_to_native:
filtered[ev] = handlers
else:
print(
f"\u26a0\ufe0f {integration.key} does not support '{ev}' events; skipping",
file=sys.stderr,
logger.warning(
"%s does not support '%s' events; skipping", integration.key, ev,
)

# #3: an empty resolved map (--events false, or override disabling events)
Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/test_integration_vibe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,14 +217,14 @@ def test_wildcard_matcher_omitted(self, tmp_path):
(hook,) = self._parse(tmp_path)["hooks"]
assert "match" not in hook

def test_unsupported_events_are_skipped(self, tmp_path, capsys):
def test_unsupported_events_are_skipped(self, tmp_path, caplog):
self._install(tmp_path, {
"session_start": [{"command": "speckit.agent-context.update"}],
"pre_tool_use": [{"command": "speckit.tdd.validate"}],
})
hooks = self._parse(tmp_path)["hooks"]
assert [h["type"] for h in hooks] == ["pre_tool"]
assert "does not support 'session_start'" in capsys.readouterr().err
assert "does not support 'session_start'" in caplog.text

def test_multiple_handlers_get_unique_names(self, tmp_path):
"""Vibe drops duplicate hook names, so shared command stems must not collide."""
Expand Down