fix(integrations): drop invalid --model/--output-format flags from Vibe dispatch - #4784
Merged
Merged
Conversation
…be dispatch The Mistral Vibe CLI has no --model and no --output-format flag, so the inherited SkillsIntegration.build_exec_args() made a dispatched step exit 2 at argument parsing whenever a model was configured or JSON output was requested. Keep -p, map output_json to Vibe's own --output json, and drop model: Vibe picks its model from active_model in its config. Assisted-by: Claude Code (model: Claude Opus 5.5, autonomous)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches Vibe 2.25.8’s CLI contract and includes focused positive and negative regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects Vibe workflow dispatch to use supported CLI flags.
Changes:
- Maps JSON output to
--output json. - Drops unsupported per-invocation model flags.
- Adds regression coverage for prompt mode, JSON output, model omission, and extra arguments.
| File | Description |
|---|---|
src/specify_cli/integrations/vibe/__init__.py |
Adds Vibe-specific execution arguments. |
tests/integrations/test_integration_vibe.py |
Covers corrected dispatch behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Mistral Vibe CLI has no
--modeland no--output-formatflag (checked on the latest release, 2.25.8).VibeIntegrationinheritsSkillsIntegration.build_exec_args(), which appends both, so a dispatched step exits 2 at argument parsing whenever either one ends up in the argv: a workflow step (or workflow default) that setsmodel:, oroutput_json=True.Same shape as the Forge (#4667) and Amp (#4581) fixes:
-p, Vibe's programmatic modeoutput_jsonto Vibe's own--output jsonmodel: Vibe has no per-invocation model flag and picks its model fromactive_modelin its config (orVIBE_ACTIVE_MODEL)Vibe is one of the unverified integrations listed in #2416.
Reproduction on current
mainwith vibe 2.25.8 onPATH(no API key configured) and this workflow in a project initialized with--integration vibe:specify workflow run repro.yml:With this change the step reaches Vibe itself and stops only at the missing credentials:
The JSON flag directly:
vibe -p x --output-format jsonexits 2 withunrecognized arguments: --output-format, whilevibe -p x --output jsonparses.Testing
Tested locally with
uv run specify --helpRan existing tests with
uv sync && uv run pytestTested with a sample project (if applicable)
New tests in
tests/integrations/test_integration_vibe.py: prompt mode,--output json,modeldropped, extra args. The last three fail onmainand pass with the change.Full suite: 8536 passed, 214 skipped (Linux, Python 3.13)
uvx ruff@0.15.0 check src tests: cleanSample project: the workflow above against
mainand this branch, vibe 2.25.8.AI Disclosure
AI disclosure: Claude Code (Claude Opus 5.5, max reasoning effort, autonomous agent mode) was used for drafting/refactoring the code change, the regression tests and this description.