fix: recognize community submission types and report workflow outcomes - #4829
Merged
KSchlobohm merged 1 commit intoOct 3, 2026
Merged
Conversation
Assisted-by: GitHub Copilot App (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Deterministic reporting is well tested, but agent-driven type classification still requires final human review.
Review effort: Balanced
Findings: None
What changed in this PR
Improves community submission recognition and guarantees explicit workflow outcomes.
Changes:
- Shares flexible extension, preset, and bundle intake guidance.
- Adds deterministic fallback reporting for missing or incomplete outcomes.
- Adds regression tests, documentation, and regenerated workflows.
| File | Description |
|---|---|
.github/workflows/shared/catalog-submission.md |
Defines shared intake and outcome reporting. |
.github/workflows/add-community-extension.md |
Imports shared extension intake guidance. |
.github/workflows/add-community-extension.lock.yml |
Compiles extension reporting changes. |
.github/workflows/add-community-preset.md |
Imports shared preset intake guidance. |
.github/workflows/add-community-preset.lock.yml |
Compiles preset reporting changes. |
.github/workflows/add-community-bundle.md |
Imports shared bundle intake guidance. |
.github/workflows/add-community-bundle.lock.yml |
Compiles bundle reporting changes. |
tests/test_submission_outcomes.py |
Covers reporting success and failure paths. |
docs/guides/agentic-sdlc.md |
Documents intake and fallback behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 3, 2026
KSchlobohm
added a commit
that referenced
this pull request
Oct 3, 2026
Create space for additional hosted validation before proceeding with or reintroducing the changes from #4829. Assisted-by: GitHub Copilot App (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace exact title-prefix gates in extension, preset, and bundle submission workflows with shared title/body intake instructions. Accept case, whitespace, optional-colon, and submission-title variants. Clear type-specific body fields take precedence; incidental dependency/component words do not establish a type.
Wrong-type and unclear issues receive an explanation and stop without validation, catalog edits, PRs, or label changes. Maintainers own relabeling; this does not automatically route submissions.
Require an explicit outcome, reason, owner/next action, and exact run-attempt link. Add a shared deterministic
submission_outcomejob for missing outcomes and incomplete agent/safe-output processing. It recognizes PAT-authored safe-output comments through the exported comment ID, deduplicates only explicit outcomes linked to the same attempt, and requires zero failed/deferred/cancelled item counters to confirm completion. Missing counters remain unconfirmed; incomplete processing is Blocked, retaining a confirmed published PR link where available.Existing artifact validation and label-application behavior are unchanged. This excludes the separately fixed ZIP-fixture issue and the label-application fix already upstream.
User-reported context: #4670 describes a mislabeled preset; #4729, #4803, and #4802 supplied title-variant examples. These are context, not issues this PR closes.
Testing
uv run specify --helpuv sync && uv run pytestUsed this worktree's own virtual environment rather than the template's bare
uv run pytest. Exact local commands/results on Windows, Python 3.11.5:uv sync --extra test: passed; created the missing worktree virtual environment.gh aw compile add-community-extension add-community-preset add-community-bundle --no-check-update: passed, 3 compiled, 0 warnings, using the existing v0.88.7 compiler. Removed only its duplicate.gitattributesaddition..\.venv\Scripts\python.exe -m pytest tests\test_submission_outcomes.py tests\test_github_workflows.py -q: 144 passed, 16 skipped..\.venv\Scripts\specify.exe --help: passed.git diff --check HEAD: passed.Before/after regression evidence: the three parametrized
test_submission_reporting_is_wired_into_compiled_workflowcases fail against unchanged upstreame1fa857awith missing shared imports; all pass with this patch. An isolated temporary baseline tree was used without modifying the working patch.Hosted fork evidence at source revision
08bafe9a(all five runs concluded success, with one explicit outcome per case and successful reporting jobs):Extension submission:[Preset]without colon[Bundle Submission]Fixture titles/bodies/labels were restored after those tests. Agent failures, missing outcomes, PAT deduplication, and item-level safe-output failures have automated local coverage, not hosted failure-injection coverage. Type recognition is agent-driven; local deterministic tests do not prove every prompt variant.
No slash commands or project scaffolding changed, so sample-project testing is not applicable. The full Python suite and upstream hosted CI were not run for this isolated patch. Earlier fork CI at
08bafe9aencountered the pre-existing timestamp-dependent ZIP-fixture checksum test failure; later passing fork CI included a separate fix and is not evidence of full CI for this PR.AI Disclosure
AI disclosure: Upstream preparation used GitHub Copilot App powered by GPT-6.1 Sol (
gpt-6.1-sol) in autonomous mode, with runtime-default reasoning effort (not explicitly overridden). It applied the existing fork change, regenerated workflow YAML with gh-aw, inspected scope, ran local checks, and drafted this PR description. The original fork work also used GitHub Copilot App, with GPT-6.1 Sol and GPT-5.6 Sol Fast used during the session, for workflow instructions, reporting code, tests, documentation, and review-driven fixes under human direction; the exact reasoning settings for that earlier work were not recorded.