Repository navigation
fix(powershell): treat bracketed feature paths literally - #4970
Open
WOLIKIMCHENG wants to merge 2 commits into
Open
WOLIKIMCHENG wants to merge 2 commits into
WOLIKIMCHENG wants to merge 2 commits into
Conversation
Assisted-by: Codex CLI (model: gpt-5.6-terra, autonomous)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused literal-path changes include positive and negative regression coverage, with no blocking issues identified.
0 open findings
What changed in this PR
Fixes PowerShell task setup and prerequisite checks for feature directories containing square brackets.
Changes:
- Uses literal paths for feature-derived file checks and directory enumeration.
- Adds regression tests for bracketed directories and rejection of wildcard-matching neighbors.
Reported test results were not independently rerun.
| File | Description |
|---|---|
| tests/test_setup_tasks.py | Adds bracketed-path success and neighbor-rejection tests. |
| tests/test_check_prerequisites_python_parity.py | Tests literal paths across prerequisite output modes. |
| scripts/powershell/setup-tasks.ps1 | Uses literal paths for required and optional documents. |
| scripts/powershell/common.ps1 | Makes shared file and directory checks literal. |
| scripts/powershell/check-prerequisites.ps1 | Uses literal paths for prerequisites and document discovery. |
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Please address test & lint errors |
mnriem
added
the
triage-must-have
Assisted-by: Codex CLI (model: gpt-5.6-terra, autonomous)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PowerShell can treat square brackets in a feature directory name as wildcards, causing task setup or prerequisite checks to miss existing files or match a neighboring directory.
Testing
git diff --checkpassed.AI Disclosure
AI disclosure: AI-assisted tools were used to implement the fix and develop tests.