Skip to content

fix(cast): list built-in members in team.md so every host sees the same roster - #2523

Merged
bradygaster merged 3 commits into
devfrom
fix/2522-cast-builtin-roster
Nov 17, 2026
Merged

bradygaster merged 3 commits into
devfrom
fix/2522-cast-builtin-roster

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

Closes #2522.

What was wrong

When a team is cast with squad cast --name (the path Claude Code's coordinator uses), team.md ended up listing only the cast members. squad init creates the charters for Scribe, Ralph, Rai and Fact Checker but leaves the roster empty, and squad cast only added the member being cast. Claude's coordinator still reported the built-ins (its prompt says they always exist). Copilot reads the roster from team.md, so it reported a smaller team. Copilot also listed the ## Coordinator row ("Squad") as if it were a team member.

Found in a live Copilot ↔ Claude handoff test; details and repro are in the issue.

Changes

  • squad cast adds the ## Built-in Support Agents table when the built-in charters exist and team.md doesn't list them anywhere. It's the same table and placement createTeam already writes (before ## Coding Agent / ## Project Context), and it's idempotent. It stays out of ## Members, so Init Mode's "empty roster" check still counts cast members only.
  • Coordinator wording, in the Copilot template (synced to every copy) and the shared coordinator source for the other hosts: a roster answer lists the members and built-ins, and the coordinator describes itself separately instead of listing itself.
  • Regenerated plugins/squad/agents/squad.md and the Copilot projection snapshot. Added a changeset.

Tests

  • New in test/cli/cast.test.ts: casting into an init-shaped roster adds the built-ins exactly once, outside ## Members and before ## Project Context. A roster that already lists them under ## Members is left alone. No rows are added when no built-in charters exist.
  • cast, claude-plugin and host-projection-regression-guards pass. In the full suite, 7 other files failed under full parallel load (stress, hostile-integration, gh-aw, init-leak, leakage scanner, cli). The set changed between runs, and all of them pass when run on their own.

Not covered

The coordinator wording change is a prompt change, so it isn't unit-testable. It needs a live check: in a fresh squad init --client copilot,claude repo, cast with Claude, then ask Copilot "who's on the team?".

🤖 Generated with Claude Code

…me roster (#2522)

`squad init` scaffolds the Scribe, Ralph, Rai and Fact Checker charters but leaves the
roster empty, and `squad cast --name` only adds the member being cast. A team cast that
way (Claude Code's Init Mode path) had no built-ins in team.md, so Copilot, which reads
the roster from team.md, reported a smaller team than Claude did.

- squad cast adds the `## Built-in Support Agents` table (the same one createTeam
  writes) when the built-in charters exist and team.md doesn't list them anywhere.
  It stays out of `## Members`, so Init Mode's empty-roster check is unaffected.
- Coordinator wording (Copilot template and the shared source for other hosts): a
  roster answer lists the members and built-ins and describes the coordinator
  separately, instead of listing "Squad" as a member.
- Regenerated the Claude plugin tree and the Copilot projection snapshot.

Closes #2522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI adaptive review requested due to automatic review settings November 17, 2026 04:10
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

🟠 Impact Analysis — PR #2523

Risk tier: 🟠 HIGH

📊 Summary

Metric Count
Files changed 12
Files added 0
Files modified 12
Files deleted 0
Modules touched 6

🎯 Risk Factors

  • 12 files changed (6-20 → MEDIUM)
  • 6 modules touched (5-8 → HIGH)

📦 Modules Affected

ci-workflows (1 file)
  • .github/agents/squad.agent.md
root (3 files)
  • CHANGELOG.md
  • plugins/squad/agents/squad.md
  • templates/squad.agent.md.template
squad-cli (3 files)
  • packages/squad-cli/src/cli/commands/cast.ts
  • packages/squad-cli/src/cli/core/cast.ts
  • packages/squad-cli/templates/squad.agent.md.template
squad-sdk (2 files)
  • packages/squad-sdk/src/client/adapters/coordinator.ts
  • packages/squad-sdk/templates/squad.agent.md.template
templates (1 file)
  • .squad-templates/squad.agent.md
tests (2 files)
  • test/__snapshots__/host-projection-regression-guards.test.ts.snap
  • test/cli/cast.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

Authoritative evidence: scanners from the PR base commit, posted by the default-branch workflow_run reporter.
Results for head commit 0ae302351098f500c8ff6126956a0247f5f277ad.

⚠️ Architectural review: 1 warning(s).

Severity Category Finding Files
🟡 warning bootstrap-area 1 file(s) in the bootstrap area (packages/squad-cli/src/cli/core/) were modified. These files must maintain zero external dependencies. Review carefully. packages/squad-cli/src/cli/core/cast.ts

Automated architectural review — informational only.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 0ae3023

PR Scope: 📦🔧 Mixed (product + infrastructure)

⚠️ 3 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present CHANGELOG.md edit found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved 0 active Copilot thread(s) resolved (2 outdated skipped)
❌ CI passing 15 check(s) still running

Files Changed (12 files, +184 −3)

File +/−
.github/agents/squad.agent.md +2 −0
.squad-templates/squad.agent.md +2 −0
CHANGELOG.md +1 −0
packages/squad-cli/src/cli/commands/cast.ts +20 −0
packages/squad-cli/src/cli/core/cast.ts +44 −0
packages/squad-cli/templates/squad.agent.md.template +2 −0
packages/squad-sdk/src/client/adapters/coordinator.ts +1 −1
packages/squad-sdk/templates/squad.agent.md.template +2 −0
plugins/squad/agents/squad.md +1 −1
templates/squad.agent.md.template +2 −0
test/__snapshots__/host-projection-regression-guards.test.ts.snap +1 −1
test/cli/cast.test.ts +106 −0

Total: +184 −3


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Built-in roster handling can duplicate existing support agents and add entries whose charters do not exist because the guards check only for Scribe.

2 open issues
What changed in this PR

This PR addresses #2522 by aligning roster reporting across Copilot and Claude Code, using team.md to expose built-in support agents alongside cast members.

Changes:

  • Adds a built-in support table during squad cast, outside ## Members to preserve Init Mode detection.
  • Updates coordinator prompts to include support agents and describe the coordinator separately.
  • Adds roster regression tests, refreshes generated artifacts, and records patch changesets.
File Description
test/​cli/​cast.test.ts Tests support-table insertion, placement, and repeated casting.
test/​__snapshots__/​host-projection-regression-guards.test.ts.snap Refreshes the Copilot projection hash.
templates/​squad.agent.md.template Syncs roster-answer guidance.
plugins/​squad/​agents/​squad.md Updates the generated plugin coordinator prompt.
packages/​squad-sdk/​templates/​squad.agent.md.template Syncs guidance into SDK templates.
packages/​squad-sdk/​src/​client/​adapters/​coordinator.ts Updates shared cross-host roster instructions.
packages/​squad-cli/​templates/​squad.agent.md.template Syncs guidance into CLI templates.
packages/​squad-cli/​src/​cli/​core/​cast.ts Adds the support-section insertion helper.
packages/​squad-cli/​src/​cli/​commands/​cast.ts Calls roster enrichment after casting a member.
.squad-templates/​squad.agent.md Adds canonical Copilot roster-answer guidance.
.github/​agents/​squad.agent.md Syncs the repository coordinator prompt.
.changeset/​cast-builtin-roster.md Records CLI and SDK patch releases.

Review effort: Balanced (adaptive)

Comment thread packages/squad-cli/src/cli/core/cast.ts Resolved
…eview)

Add a row only for a built-in whose charter exists and that the roster doesn't
already list (by charter path or name row), instead of using Scribe as the
sentinel for all four.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bradygaster
bradygaster enabled auto-merge (squash) November 17, 2026 04:28
@bradygaster
bradygaster merged commit febc6b4 into dev Nov 17, 2026
32 checks passed
bradygaster added a commit that referenced this pull request Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

squad cast leaves built-ins (Scribe, Ralph, Rai, Fact Checker) out of team.md, so Claude and Copilot report different rosters

2 participants