docs(network): fix ecosystem identifier list and topology-attach description - #2144
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Documentation Update
Findings
copilot-vendorecosystem identifier exists insrc/data/ecosystem_domains.jsonbut was missing from the "Additional ecosystems" listdocs/network.md--topology-attachdescription only documented the always-on MCPG attach (awmg-mcpg); it omitted the conditional second attach for the credential-isolatedado-proxysidecar (awmg-ado-proxy) thatsrc/compile/agentic_pipeline.rsemits on the Agent job whenpermissions.readis configureddocs/network.mdApplied Fixes
copilot-vendorto the "Additional ecosystems" list--topology-attachinvocations (MCPG always,ado-proxyconditionally) and cross-linkeddocs/ado-proxy-design.mdNotes
Verified against code:
src/data/ecosystem_domains.jsontop-level keys (41 ecosystems) vs. the identifiers listed/tabulated indocs/network.md—copilot-vendorwas the only gap.src/compile/agentic_pipeline.rs(topology_attach_block,MCPG_CONTAINER_NAME,ADO_PROXY_CONTAINER_NAME, and the test asserting 2--topology-attachflags when ado-proxy is enabled) confirms the Agent job conditionally emits a second--topology-attachfor the ado-proxy sidecar, which the doc previously omitted.Checked open PRs for overlap: none of the currently open PRs touch
docs/network.md; the recurringcontainer_runtime.rsAGENTS.md PRs are unrelated to this change.Created by the agent-documentation maintainer workflow.