refactor: reduce complexity of add_ado_proxy_findings in src/audit/findings.rs

[github-actions]

Summary

add_ado_proxy_findings in src/audit/findings.rs was flagged by clippy::too_many_lines at 219/100 lines. It contained seven independent if-guarded blocks, each constructing and pushing one Finding + one Recommendation pair based on a distinct ado-proxy analysis condition (unhealthy lifecycle, credential unavailable, upstream failed, out-of-scope response, prompt conflicts, prohibited requests, malformed records).

Change

Extracted each block into its own small, descriptively-named helper function using an early-return guard clause (matching the style already used by sibling add_* rule functions in this module):

• add_ado_proxy_unhealthy_lifecycle_finding
• add_ado_proxy_credential_unavailable_finding
• add_ado_proxy_upstream_failed_finding
• add_ado_proxy_out_of_scope_response_finding
• add_ado_proxy_prompt_conflict_finding
• add_ado_proxy_prohibited_request_finding
• add_ado_proxy_malformed_record_finding

add_ado_proxy_findings now short-circuits on a missing ado_proxy_analysis and calls each helper in sequence — no behavior change.

Verification

• cargo build — clean
• cargo test --bin ado-aw — all 3358 tests pass (0 failed), including all 18 existing audit::findings tests unmodified
• cargo clippy --all-targets --all-features — clean
• clippy::too_many_lines no longer fires for this file (previously reported as 219/100)

Before / after complexity

	Lines	Lint
Before	219/100	clippy::too_many_lines
After	split across 8 functions, largest ~55 lines	none

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Cyclomatic Complexity Reducer · auto · 82.9 AIC · ⌖ 13.6 AIC · ⊞ 10.2K · ◷

[azure-pipelines]

Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.