Skip to content

[use-effect] Fix reset-or-adjust-state Effect in callout heading picker #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[use-effect] Fix reset-or-adjust-state Effect in callout heading picker #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/editor/src/widgets/callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,14 @@ function Heading(
});
}, [editor, callout.key]);

useEffect(() => {
if (disabled) setChoosing(false);
}, [disabled]);
// Becoming disabled must close the picker immediately, not on the next
// render pass — derive it during render instead of adjusting state in an
// Effect after the fact.
let disabledForRender = useRef(disabled);
if (disabledForRender.current !== disabled) {
disabledForRender.current = disabled;
if (disabled && choosing) setChoosing(false);
}

let choose = (value: string) => {
if (disabledRef.current) return;
Expand Down