Repository navigation
Conversation
- Require phpBB >=3.3.0 and PHP >=7.2, drop outdated dev dependencies - ext.php: use language service, fix soft-require key and regex range - Notifications: use language service for titles - Tests: run on PHPUnit 9 (replace removed assertAttributeEmpty, new phpunit.xml) - Replace Travis setup by GitHub Actions workflow, add dev scripts for local tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
- composer.json: allow the installer plugins required for the vendor dependencies (Composer 2) - Add fresh composer.lock - Functional tests: use assertStringContainsString instead of removed string support in assertContains - Add dev/run-functional-tests.sh for running the functional tests headless Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
- composer.json: allow phpBB >=3.2.2 and PHP >=5.4, drop composer.lock (resolved per PHP version) - Tests: assertions that work on PHPUnit 4 (phpBB 3.2) and 9 (phpBB 3.3) - CI: use test-framework@3.3.x (master targets phpBB 4) incl. composer install, separate workflow for phpBB 3.2.x - Rename dev/ to develop/ (skipped by the executable files check), add develop/check.sh mirroring the CI checks - Fix code sniffer findings Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
phpBB 3.2.x does not support PHP 7.3+, and a ': void' return type breaks PHP < 7.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
gn36
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the extension run on phpBB 3.2.x and 3.3.x (including PHP 8), analogous to gn36/phpbb-ext-versionchecknotifier#18, and sets up automated tests.
>=3.2.2,<3.4@dev, PHP>=5.4; remove outdated dev dependencies; allow the Composer 2 installer plugins needed for the vendor dependencies (composer installfailed without this);composer.lockis no longer tracked (resolved per PHP version)languageservice; fix thesoft_requirekey (it issoft-require, so the phpBB version check never ran); fix an accidental character range in the version regexlanguageservicedate_idneedsSET IDENTITY_INSERT); found by the CI database matrixuseconflicts)tests/compat.phptrait instead ofassertContainswith strings, nosetUp(): void, noassertAttributeEmpty; newphpunit.xml.distphpbb-extensions/test-framework@3.3.x(master of the framework targets phpBB 4), incl.composer installfor the functional tests; sniffer, EPV, ICC, executable check, all databases, PHP 7.2 to 8.4tests-3.2.yml(PHP 5.6, 7.1, 7.2; phpBB 3.2.x itself does not support PHP 7.3+), unit and functional testsbuild.xmlandtravis/removeddevelop/scripts:check.sh(same checks as the CI),run-tests.sh,run-functional-tests.sh,cloud-setup.sh(the directory is nameddevelopbecause the executable files check skips it)Test plan
Notes:
composer.pharis still tracked and untouched; the packageversionincomposer.jsonwas kept (required by phpBB) and not bumped. PHP 5.4/5.5 is not covered by the CI (not available in the runner setup), phpBB 3.1 is not supported.🤖 Generated with Claude Code
https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf