Skip to content

Class phpbb\language\language must be used for notifications / Notification adjustments #3

Closed

Description

@gn36

The constructor has changed and must be adjusted. Other changes from phpBB.com Notes:

Notifications (3.2 only)
If your extension uses the notifications system by extending the notifications class, then you should take a look at how the notifications classes have changed for 3.2. The notable changes are made to the find_users_for_notification and create_insert_array methods.

public function find_users_for_notification($data, $options = array())
{
    ...
    // phpBB 3.1 usage:
    $users[$row['user_id']] = array('');

   // phpBB 3.2 usage:
    $users[$row['user_id']] = $this->notification_manager->get_default_methods();
    ...
} 
public function create_insert_array($data, $pre_create_data = array())
{
    ...
    // phpBB 3.1 usage:
    return parent::create_insert_array($data, $pre_create_data);

   // phpBB 3.2 usage:
    parent::create_insert_array($data, $pre_create_data);
} 

Activity

  1. added this to the 1.1.0 milestone on May 4, 2016
  2. gn36 commented on Oct 18, 2026

    @gn36
    OwnerAuthor

    Erledigt mit dem 3.3-Port (#18): neuer Konstruktor der Basisklasse, language-Service statt user->lang, find_users_for_notification liefert die Methoden aus check_user_notification_options(), create_insert_array ohne Rückgabewert (#19).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions