Repository navigation
chore(deps): require goaop/parser-reflection 4.0.1 or 5.0.1 - #744
Merged
Merged
Conversation
Both releases create the parser and the name resolver on the first parse instead of when the library is loaded, so a request served from the AOP cache no longer pays for them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bYFRwMWKndKaj6SemwDn2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=========================================
Coverage 97.54% 97.54%
Complexity 1802 1802
=========================================
Files 102 102
Lines 4772 4772
=========================================
Hits 4655 4655
Misses 117 117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #730. This raises the
goaop/parser-reflectionrequirement from^4.0 || ^5.0to^4.0.1 || ^5.0.1.Both releases create the PHP-Parser instance and the name-resolving traverser on the first parse, instead of when the library's composer
filesbootstrap loads. A request served entirely from the AOP cache never parses anything, so it no longer builds them (goaop/parser-reflection#238, #239).The Requirements line in CHANGELOG.md and the upgrade guide now name both majors with the new minimum.
Checklist
type(scope): summary)composer update goaop/parser-reflection.composer checkpasses: phpunit 2991 tests, phpstan, cs, andcomposer validate. Locally the suite ran with the opcache JIT disabled.🤖 Generated with Claude Code
https://claude.ai/code/session_019bYFRwMWKndKaj6SemwDn2
Generated by Claude Code