Skip to content

chore(deps): require goaop/parser-reflection 4.0.1 or 5.0.1 - #744

Merged
lisachenko merged 1 commit into
masterfrom
chore/bump-parser-reflection
Oct 7, 2026
Merged

lisachenko merged 1 commit into
masterfrom
chore/bump-parser-reflection

Conversation

@lisachenko

Copy link
Copy Markdown
Member

What and why

Follow-up to #730. This raises the goaop/parser-reflection requirement from ^4.0 || ^5.0 to ^4.0.1 || ^5.0.1.

Both releases create the PHP-Parser instance and the name-resolving traverser on the first parse, instead of when the library's composer files bootstrap loads. A request served entirely from the AOP cache never parses anything, so it no longer builds them (goaop/parser-reflection#238, #239).

The Requirements line in CHANGELOG.md and the upgrade guide now name both majors with the new minimum.

Checklist

  • The title follows Conventional Commits (type(scope): summary)
  • Tests cover the change: no code change. The suite ran against parser-reflection 5.0.1 after composer update goaop/parser-reflection.
  • composer check passes: phpunit 2991 tests, phpstan, cs, and composer validate. Locally the suite ran with the opcache JIT disabled.
  • User-facing or breaking changes are in CHANGELOG.md (and the upgrade guide for breaking changes): the requirement is updated in both.

🤖 Generated with Claude Code

https://claude.ai/code/session_019bYFRwMWKndKaj6SemwDn2


Generated by Claude Code

Both releases create the parser and the name resolver on the first parse instead of when the library is loaded,
so a request served from the AOP cache no longer pays for them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019bYFRwMWKndKaj6SemwDn2
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (8b03f6f) to head (7f2bcb8).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #744   +/-   ##
=========================================
  Coverage     97.54%   97.54%           
  Complexity     1802     1802           
=========================================
  Files           102      102           
  Lines          4772     4772           
=========================================
  Hits           4655     4655           
  Misses          117      117           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lisachenko
lisachenko marked this pull request as ready for review October 7, 2026 16:25
@lisachenko
lisachenko merged commit c3fcd30 into master Oct 7, 2026
14 checks passed
@lisachenko
lisachenko deleted the chore/bump-parser-reflection branch October 7, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants