net: eliminate bounds checks in hasUpperCase by jub0bs · Pull Request #78311 · golang/go

jub0bs · 2026-03-24T10:04:29Z

Function hasUpperCase accesses its parameter's bytes while iterating
over its runes. This approach muddles intent and causes an unnecessary
bounds check.

This CL makes hasUpperCase iterate over its parameter's bytes instead.

Updates #76354

gopherbot · 2026-03-24T10:11:11Z

This PR (HEAD: 152ccbb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/758600.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-24T10:22:37Z

This PR (HEAD: 500d421) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/758600.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-24T10:32:54Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-24T10:42:42Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-24T10:42:43Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-24T11:01:35Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-24T11:11:15Z

This PR (HEAD: c0f1ab3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/758600.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-24T11:35:53Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-02T23:14:40Z

Message from Olivier Mengué:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-07T12:07:47Z

Message from Daniel Martí:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-07T13:45:37Z

Message from Jorropo:

Patch Set 3: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-07T14:11:39Z

Message from jub0bs:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-07T14:11:40Z

Message from Daniel Martí:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-07T14:37:18Z

Message from Jorropo:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-05-29T07:58:14Z

Message from Daniel Martí:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T11:22:52Z

Message from jub0bs:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T18:03:39Z

Message from Daniel Martí:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T18:16:27Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-06-06T17:54:41Z","revision":"eca78d4af98a9bcdb3e3a836bd9058f034b1c17e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T18:28:55Z

Message from Daniel Martí:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_13550>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T18:28:56Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64_debian13 has failed with summary (view all results):

go on master (change 758600)

To reproduce, try gomote repro 8679722618051218561.

Additional links for debugging:

go tool dist test -json output [shard 3]

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-06T18:28:56Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T09:50:49Z

Message from Daniel Martí:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

Function hasUpperCase accesses its parameter's bytes while iterating over its runes. This approach muddles intent and causes an unnecessary bounds check. This CL makes hasUpperCase iterate over its parameter's bytes instead. Updates golang#76354

gopherbot · 2026-06-07T10:20:13Z

This PR (HEAD: aa226a0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/758600.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-06-07T10:32:38Z

Message from jub0bs:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T11:58:58Z

Message from Daniel Martí:

Patch Set 4: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T12:11:58Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-06-07T11:52:22Z","revision":"f16c2ec30caf9e351e75d97aec8af24783339bb9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T12:23:57Z

Message from Daniel Martí:

Patch Set 4: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_13550>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T12:23:58Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T12:23:58Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-07T13:08:14Z

Message from Daniel Martí:

Patch Set 4: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-06-10T21:27:36Z

Message from Cherry Mui:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/758600.
After addressing review feedback, remember to publish your drafts!

jub0bs force-pushed the bce-in-net-hasuppercase branch from 152ccbb to 500d421 Compare March 24, 2026 10:12

jub0bs force-pushed the bce-in-net-hasuppercase branch from 500d421 to c0f1ab3 Compare March 24, 2026 11:10

jub0bs force-pushed the bce-in-net-hasuppercase branch from c0f1ab3 to aa226a0 Compare June 7, 2026 10:13

Conversation

jub0bs commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Mar 24, 2026

Uh oh!

gopherbot commented Apr 2, 2026

Uh oh!

gopherbot commented Apr 7, 2026

Uh oh!

gopherbot commented Apr 7, 2026

Uh oh!

gopherbot commented Apr 7, 2026

Uh oh!

gopherbot commented Apr 7, 2026

Uh oh!

gopherbot commented Apr 7, 2026

Uh oh!

gopherbot commented May 29, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 6, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 7, 2026

Uh oh!

gopherbot commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jub0bs commented Mar 24, 2026 •

edited

Loading