Fix SD-JWT decoder to handle delegation chains - #350
Closed
maxcabd wants to merge 1 commit into
Closed
Conversation
sdJwtDecoder.ts split on a single `~` before checking for the `~~` chain separator, so a genuine delegation-chain token (the common shape for real Checkout/Payment mandate flows) was silently mis-decoded: the second hop's issuer-signed JWT was misread as a trailing KB-JWT, and that hop's own disclosures were dropped or misattributed to hop 0. decodeSdJwt/decodeSdJwtSync now split on `~~` first and decode each hop independently. DecodedSdJwt gains an optional `hops` array (one entry per hop, fully decoded); the existing top-level issuerJwt/disclosures/kbJwt fields still describe hop 0, so every existing single-hop caller (including MandateCard.tsx) is unaffected. Added vitest (this package had no test runner) and a test using a real 2-hop chain from the Python reference SDK. Verified the new test fails against the pre-fix code and passes after the fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfCaW4RbZQgTpcyXRau8os
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A display bug in the sample UI.
sdJwtDecoder.tssplits on a single~before checking for the~~chain separator used by delegation chains. When a token is a real chain, which is common for Checkout and Payment mandates, this misreads the second hop as a trailing KB JWT and drops that hop's disclosures.The fix splits on
~~first and decodes each hop on its own.DecodedSdJwtnow has an optionalhopsfield with one entry per hop. The existingissuerJwt,disclosures, andkbJwtfields still describe hop 0, soMandateCard.tsxand any other caller keep working without changes. Confirmed withtsc --noEmit.Added
vitest, since this package didn't have a test runner, and a test using a real two hop chain from the Python SDK. The test fails on the old code and passes after the fix.