generator: correct failure feedback and paper semantics - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix failure-discovery behavior found while checking Sections 2.4 and 3.1 and Algorithm 2 of the paper: https://arxiv.org/html/2604.23099v1
generate()→update(score)loop to topic statistics.Known limitation
The current score-only
update(score)API cannot condition the GP on a newly generated input: it lacks that input's embedding or kernel covariances. This PR corrects the misleading docstrings and topic feedback but does not invent a generated-point covariance or assign its score to an anchor. Full generated-input GP conditioning remains a separate API gap; this PR does not claim complete Algorithm 2 conformance.Verification
123 passed, including PyTorch paths.