evaluator: preserve signed GSM8K ground-truth answers - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve optional
+/-signs when extracting GSM8K ground-truth answers, both after####and in the plain-number fallback.Bug
During a live OpenRouter smoke test, Gemini 2.5 Flash Lite correctly returned
-3for a temperature changing from 2 to -3. With reference#### -3, ProEval stripped the minus sign, compared against3, and returned error score1.0.When a signed final answer followed earlier numbers in the solution, the
####pattern failed entirely and the fallback could select an unrelated earlier number.The fix changes only the two extraction regexes. Existing comma handling and final-answer precedence are preserved.
Verification
-3and-1234.5; both now receive error score0.0, including a comma-formatted reference with earlier reasoning numbers.123 passed.