Exclude name from the ExecutableSpec field copy - #72
Open
evanjpw wants to merge 1 commit into
Open
Conversation
The loop that fills ExecutableSpec copies across every field it does not set explicitly, and name is one of them. An executable's name comes from its build target, so it carries characters that are legal in a target label but not in the RFC 1123 DNS label the server requires, and every work unit is rejected: work_unit.executable.jobset.jobs.spec.name must be a valid DNS label The sibling loop for KubernetesJob already lists name among its explicit fields for the same reason.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
evanjpw
force-pushed
the
evan/upstream-executable-name
branch
from
August 19, 2026 12:06
a02d68f to
2ba119c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_convert_xm_job_to_ess_jobfillsExecutableSpecby setting four fields explicitly and copying every remaining field offjob.executableby matching field names.ExecutableSpechas anamefield andxm.Executablehas anameattribute, so an executable's build-target label is copied intoExecutableSpec.name. That label is legal in Bazel and not in the RFC 1123 DNS label the server requires, so every work unit submitted throughxm_cloudis rejected:The sibling loop for
KubernetesJobalready listsnameamong its explicit fields for the same reason, so this makes the two consistent.Reproduced against XMC
0.3.0with a Bazel-packaged executable, where the generated name contains underscores.