Fix install_xmanager_cloud.sh against the current API - #73
Open
evanjpw wants to merge 1 commit into
Open
Conversation
The script copies two of the three proto directories xmc now publishes. Current artifact.proto imports dashboard_service for Chart, so protoc resolves nothing and the script produces no stubs at all against the xmc tag we deploy. grpcio-tools is also pinned here. Generated code records the version that produced it and protobuf refuses to load it on an older runtime, so resolving the compiler freely yields stubs that the runtime installed beside them cannot import.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
evanjpw
marked this pull request as draft
August 19, 2026 12:02
evanjpw
marked this pull request as ready for review
August 19, 2026 12:02
evanjpw
force-pushed
the
evan/upstream-install-script
branch
from
August 19, 2026 12:06
a1ce81e to
18832f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_xmanager_cloud.shcopies two of the three proto directoriesxmcpublishes. The currentartifact.protoimportsdashboard_serviceforChart, soprotoccannot resolve that import and the script finishes having produced no stubs at all. This makes the documented install path fail against thexmctags we have tried it on, so the third directory is copied and compiled alongside the other two.grpcio-toolsis pinned in the same change. Generated code records the version that produced it, andprotobufrefuses to load it on an older runtime, so resolving the compiler freely produces stubs that the runtime installed beside them cannot import.