Fix argument escaping for direct argv backends - #76
Open
hartikainen wants to merge 3 commits into
Open
Conversation
hartikainen
force-pushed
the
fix-argument-escaping
branch
from
August 27, 2026 19:21
06e7ec7 to
204385c
Compare
Arguments that require POSIX shell quoting reach Docker, Vertex, and Kubernetes with literal quote characters because those backends pass the serialized tokens directly as `argv`. This separates shell-fragment serialization from direct-`argv` serialization, uses POSIX quoting for `tmux`, and emits Docker `ENTRYPOINT` arguments through `json.dumps`.
hartikainen
force-pushed
the
fix-argument-escaping
branch
from
August 27, 2026 19:45
204385c to
430788e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct
argvbackends receive the POSIX shell quoting produced byARG_ESCAPERas literal argument data. This one addsARGV_ESCAPERfor local Docker,Vertex,Kubernetes, and exec-form DockerENTRYPOINTarguments while preservingARG_ESCAPERfor commands interpreted by a shell.It also replaces
subprocess.list2cmdlinewith POSIX quoting in thetmuxpath and serializes DockerENTRYPOINTarguments throughjson.dumps. The tests cover JSON values across the direct-argv, shell,tmux, andENTRYPOINTboundaries.Fixes #75.