Expose job environment to ShellSafeArg in tmux - #78
Open
hartikainen wants to merge 6 commits into
Open
hartikainen wants to merge 6 commits into
hartikainen wants to merge 6 commits into
Conversation
Arguments that require POSIX shell quoting reach Docker, Vertex, and Kubernetes with literal quote characters because those backends pass the serialized tokens directly as `argv`. This separates shell-fragment serialization from direct-`argv` serialization, uses POSIX quoting for `tmux`, and emits Docker `ENTRYPOINT` arguments through `json.dumps`.
hartikainen
force-pushed
the
fix-tmux-shellsafe-env
branch
2 times, most recently
from
August 27, 2026 21:32
abdcefd to
78a036f
Compare
`tmux` prefixes environment assignments to the executable command. The shell therefore expands `ShellSafeArg` values before those assignments take effect. Export the job environment first, and reprint the launch command with `printf`, which does not interpret the backslash escapes that `echo` does in `sh`.
hartikainen
force-pushed
the
fix-tmux-shellsafe-env
branch
from
August 28, 2026 13:27
78a036f to
242f74b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tmuxprefixes environment assignments to the executable command. The shell therefore expandsShellSafeArgvalues before those assignments take effect. Export the job environment first and preserve the launch command when printing it for reuse.This was diagnosed and fixed by an LLM.