Add Direct VPC Egress support for 2nd gen Cloud Functions - #474
Open
Rohit1024 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New action inputs
The following optional inputs are added to
action.yml:networkstringprojects/PROJECT_ID/global/networks/NETWORK_NAME. Specifynetwork,subnet, or both.subnetstringprojects/PROJECT_ID/regions/REGION/subnetworks/SUBNET_NAME. Maps tosubnetworkin the Cloud Functions v2 API.network_tagsstringinternal-egress,db-client.direct_vpc_egressstringPRIVATE_RANGES_ONLYwhen direct VPC is setPRIVATE_RANGES_ONLY,private-ranges-only,ALL_TRAFFIC, orall-traffic.Key changes and implementation details
API types and client (
src/client.ts):DirectVpcEgressenum withVPC_EGRESS_PRIVATE_RANGES_ONLYandVPC_EGRESS_ALL_TRAFFIC.DirectVpcNetworkInterfacetype withnetwork,subnetwork, andtags.directVpcNetworkInterfaceanddirectVpcEgresstoCloudFunction.serviceConfig.computeUpdateMaskto includeserviceConfig.directVpcNetworkInterfaceandserviceConfig.directVpcEgresswhen set on the function object.Validation and parsing (
src/util.ts,src/main.ts):vpc_connectorand direct VPC settings.networkalone,subnetalone, or both, mappingsubnettosubnetworkfor the API.network_tagsordirect_vpc_egresswhen neithernetworknorsubnetis provided.environmentisGEN_1.direct_vpc_egressvalues from uppercase and kebab-case strings, defaulting toVPC_EGRESS_PRIVATE_RANGES_ONLYwhen direct VPC is active.Documentation and tests:
action.ymland updatedREADME.mddocs.README.md.tests/util.test.tsfor validation rules, tag trimming, and enum parsing.tests/client.test.tsfor update mask generation.Example usage