Retry failed upload

[larsmoa]

TL;DR

We sometime see that upload fails causing the action to fail. These errors seems to be intermittent, and rerunning the flow where the action is included usually resolves the issue.

Has it been considered having a numeric retry-option to allow setting a number of attempts to try uploading file(s) before failing?

Detailed design

No response

Additional information

No response

[rbtcollins]

This is the error reported:

google-github-actions/upload-cloud-storage failed with: the offset is lower than the number of bytes written. The server has 0 bytes and while 10 bytes has been uploaded - thus 10 bytes are missing. Stopping as this could result in data loss. Initiate a new upload to continue.

[R2wenD2]

It looks like we're already defaulting to 5 retries at

upload-cloud-storage/src/client.ts

Line 181 in 6397bd7

retryOptions: {

for every operation. I can make this customizable, but it seems like you may to use a relatively high number of retries.

@rbtcollins how frequently are you seeing this issue?

[rbtcollins]

@R2wenD2 I don't have a firm statistic - we're burning down a bunch of different test failures, and we've seen this at least twice from test runs in GitHub Actions, where I would expect little to no network congestion or error rates. The error seems to indicate something other than a trivial retry though.

[mortenmj]

We see this error daily, so I must assume that either the retry isn't applied in this case, or the upload is flaky enough that it fails quite frequently. I would estimate that this happens at least once in a couple of hundred uploads.

[millerick]

We see this error daily, so I must assume that either the retry isn't applied in this case, or the upload is flaky enough that it fails quite frequently. I would estimate that this happens at least once in a couple of hundred uploads.

We see this error happen multiple times per day in our pipelines when using the action to upload playwright test reports to a bucket.