Conversation
jemoreira
reviewed
Sep 24, 2026
cjreynol
force-pushed
the
super_image_flag_metrics
branch
from
September 24, 2026 23:37
368bf0d to
9917eeb
Compare
cjreynol
force-pushed
the
super_image_flag_metrics
branch
from
September 24, 2026 23:39
9917eeb to
0463564
Compare
For the `super_image_existence` metric field the existing `IsDefault` that only detects if the flag exists or not is insufficient for multi-device cases where some devices have a value specified and others do not. Bug: 476232064
Bug: 476232064
cjreynol
force-pushed
the
super_image_flag_metrics
branch
from
September 25, 2026 18:35
0463564 to
099bf31
Compare
jemoreira
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not the flag's value, but its existence in the invocation.
Bug: 476232064