Skip to content

Gather and transmit super_image_specified metrics - #3242

Queued
cjreynol wants to merge 2 commits into
google:mainfrom
cjreynol:super_image_flag_metrics
Queued

cjreynol wants to merge 2 commits into
google:mainfrom
cjreynol:super_image_flag_metrics

Conversation

@cjreynol

Copy link
Copy Markdown
Collaborator

Not the flag's value, but its existence in the invocation.

Bug: 476232064

@cjreynol
cjreynol requested a review from jemoreira September 24, 2026 22:57
@cjreynol cjreynol self-assigned this Sep 24, 2026
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Sep 24, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Sep 24, 2026
Comment thread base/cvd/cuttlefish/host/commands/assemble_cvd/flags/super_image.cc Outdated
Comment thread base/cvd/cuttlefish/metrics/guest/flag_metrics.cc Outdated
For the `super_image_existence` metric field the existing `IsDefault`
that only detects if the flag exists or not is insufficient for
multi-device cases where some devices have a value specified and others
do not.

Bug: 476232064
@cjreynol
cjreynol force-pushed the super_image_flag_metrics branch from 0463564 to 099bf31 Compare September 25, 2026 18:35
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Sep 25, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Sep 25, 2026
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Sep 25, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Sep 25, 2026
@cjreynol
cjreynol added this pull request to the merge queue Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants